-
Notifications
You must be signed in to change notification settings - Fork 166
Open
Description
Context
The openclaw-basic-memory plugin shells out to bm tool commands and parses JSON output. PR #552 adds --format json to read-note, write-note, and recent-activity. A few improvements would make the CLI a more reliable integration surface.
Issues
1. _write_note_json double round-trip
- Currently writes via
mcp_write_note.fn(), then re-resolves the entity via API client to get metadata back - The MCP tool could return entity metadata (title, permalink, file_path) directly, avoiding the second lookup
- Not blocking, but doubles the work for every write
2. _read_note_json identifier handling
- Uses
memory_url_path(identifier)which may assume the input is a memory URL or permalink - If a plain title is passed (e.g.
"My Note"instead of"my-note"or"memory://my-note"), doesmemory_url_pathresolve it correctly? - Plugin users will pass titles, permalinks, and memory URLs interchangeably
3. _recent_activity_json hardcoded pagination
page_size=50is hardcoded with no CLI passthrough- Should expose
--pageand--page-sizeoptions consistent with other commands
4. --project support on recent-activity
- PR feat: add --format json to CLI tool commands #552 adds
--projecttorecent-activity(good!) — verify it works with--format json+--projecttogether
5. Consider --format json on build-context
build-contextalways outputs JSON (no format flag). This is fine and consistent, but adding the flag for symmetry would make the CLI surface more predictable for integrators.
Related
- OpenClaw plugin issue: Plugin hardening: BmClient fixes, missing tools, and agent-memory mode openclaw-basic-memory#1
- PR feat: add --format json to CLI tool commands #552: feat/cli-format-json
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels