Now register in entity if node containing mstate is child of entity

Author: bakpaul

examples/stlib/node_modifier.py

@@ -76,15 +76,14 @@ def createScene(root):
     SParams.collision.primitives = [CollisionPrimitive.TRIANGLES]
     # # #TODO: to fix link issues for extracted geometry, it might be better to give source geometry relative link + parameters
     ## TODO: not working with static container because the init order is always wrong so that the triangle vector is always empty when initializing the container
-    SParams.collision.geometry = ExtractParameters(destinationType=ElementType.TRIANGLES, sourceParameters=SParams.geometry,dynamicTopology=True)
+    SParams.collision.geometry = ExtractParameters(destinationType=ElementType.TRIANGLES, sourceParameters=SParams.geometry)
     SParams.visual = VisualParameters()
     SParams.visual.geometry = FileParameters(filename="mesh/SofaScene/SVisu.obj")
     SParams.visual.color = [0.7, .7, 0.7, 0.8]
 
     S = ModelsNode.add(Entity, parameters = SParams)
 
     #TODO make the name automatically match the modifier type if none is given
-    #TODO why this doesn't add itself to the modelsnode "modified by" data ???
     root.add(NodeModifier, on = [ModelsNode], parameters = SimulationSolversParameters(name = "SimulationSolvers",
                                                                                      constantSparsity=False))
 

stlib/node_modifiers/footers.py

@@ -1,4 +1,6 @@
 import dataclasses
+
+from stlib.entities import EntityParameters, Entity
 from stlib.node_modifiers import BaseNodeModifierParameters, AffectedNodes
 from splib.core.enum_types import ConstraintType
 from splib.core.utils import DEFAULT_VALUE
@@ -68,7 +70,13 @@ def _addConstraintCorrectionToMechanicalNodes(node, constraintCorrectionType : s
                 if(linearSolverPath is None):
                     raise ValueError(f"No linear solver found before {child.getLinkPath()}. Please add one to fix this.")
                 child.addObject(constraintCorrectionType, linearSolver=linearSolverPath)
-                modified += [child]
+
+                if(isinstance(node, Entity)):
+                    modified += [node]
+                else:
+                    modified += [child]
+
+                break
             else:
                 modified += SimulationSettingsParameters._addConstraintCorrectionToMechanicalNodes(child, constraintCorrectionType, linearSolverPath)
         return modified