Skip to content

Factored checkLocationSpace into multiple methods in PatchUtilities#224

Open
navyacodes wants to merge 5 commits into
allison/carcade-refactor-treatfrom
feature/check-location-spaces
Open

Factored checkLocationSpace into multiple methods in PatchUtilities#224
navyacodes wants to merge 5 commits into
allison/carcade-refactor-treatfrom
feature/check-location-spaces

Conversation

@navyacodes
Copy link
Copy Markdown
Contributor

Estimated time to review: small

  • created new PatchUtilities and PatchUtilitiesTest files to contain factored static methods
  • factored out checking location space into three methods: density, height, and occupancy
  • wrote tests for these three methods

Resolves #215

@navyacodes navyacodes self-assigned this May 11, 2026
@navyacodes navyacodes marked this pull request as ready for review May 11, 2026 19:48
@navyacodes navyacodes added priority: medium Non-urgent but important task package: patch Related to the patch implementation category: util Related to the util subpackages size: small Estimated size of issue or PR is small labels May 11, 2026
@allison-li-1016
Copy link
Copy Markdown
Contributor

I think it will be better documentation wise if I merge the 'Treat' action into main first, and then merge this refactoring in afterwards. So for now, keep this branch, after I merge Treat in we can move the target from the treat branch to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: util Related to the util subpackages package: patch Related to the patch implementation priority: medium Non-urgent but important task size: small Estimated size of issue or PR is small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants