Skip to content

Conversation

@boquan-fang
Copy link
Contributor

Release Summary:

Resolved issues:

related to #2888

Description of changes:

I noticed a clippy breakage by the most recently merged commit: https://github.com/aws/s2n-quic/actions/runs/19439029952/job/55617414515. Our transitive dependency in xdp crate, aya-obj, did a release two hours ago, which bumps their MSRV to 1.87.0, while our MSRV is at 1.84.0.

Call-outs:

We should unpin this dependency once our MSRV is bumped to 1.88.0.

Testing:

CI should pass.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@boquan-fang boquan-fang requested a review from a team as a code owner November 17, 2025 19:28
@boquan-fang boquan-fang marked this pull request as draft November 17, 2025 19:29
resolver = "2"

[workspace.dependencies]
aya-obj = "=0.2.1" # new version requires MSRV 1.87.0 https://crates.io/crates/aya-obj/versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
aya-obj = "=0.2.1" # new version requires MSRV 1.87.0 https://crates.io/crates/aya-obj/versions
aya-log = "=0.2.0" # new version requires MSRV 1.87.0
aya-log-common = "=0.1.14" # new version requires MSRV 1.87.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also...

diff --git a/tools/xdp/s2n-quic-xdp/Cargo.toml b/tools/xdp/s2n-quic-xdp/Cargo.toml
index 7ed8ff56..f1005490 100644
--- a/tools/xdp/s2n-quic-xdp/Cargo.toml
+++ b/tools/xdp/s2n-quic-xdp/Cargo.toml
@@ -15,6 +15,7 @@ default = ["tokio"]
 
 [dependencies]
 aya = { version = "0.13", default-features = false }
+aya-obj = { workspace = true }
 bitflags = "2"
 errno = "0.3"
 libc = "0.2"
diff --git a/tools/xdp/tester/Cargo.toml b/tools/xdp/tester/Cargo.toml
index 1e4f84c7..ab505141 100644
--- a/tools/xdp/tester/Cargo.toml
+++ b/tools/xdp/tester/Cargo.toml
@@ -6,7 +6,8 @@ publish = false
 
 [dependencies]
 aya = { version = "0.13", features = ["async_tokio"] }
+aya-log = { workspace = true }
+aya-log-common = { workspace = true }
 clap = { version = "4.1", features = ["derive"] }
 anyhow = "1.0.68"

@dougch
Copy link
Contributor

dougch commented Nov 19, 2025

superseded by #2897

@dougch dougch closed this Nov 19, 2025
@boquan-fang boquan-fang deleted the aya-obj-pin branch November 25, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants