added testing for httpclient override

Author: kai-ion

tests/aws-cpp-sdk-core-tests/utils/stream/ChunkingInterceptorTest.cpp

@@ -6,6 +6,11 @@
 #include <aws/core/utils/crypto/CRC32.h>
 #include <smithy/client/features/ChunkingInterceptor.h>
 #include <aws/testing/AwsCppSdkGTestSuite.h>
+#include <aws/core/client/ClientConfiguration.h>
+#include <smithy/interceptor/InterceptorContext.h>
+#include <aws/core/http/HttpClient.h>
+#include <aws/core/AmazonWebServiceRequest.h>
+#include <aws/core/http/HttpTypes.h>
 
 using namespace Aws;
 using namespace Aws::Http::Standard;
@@ -14,6 +19,14 @@ using namespace Aws::Utils::Crypto;
 
 const char* CHUNKING_TEST_LOG_TAG = "CHUNKING_INTERCEPTOR_TEST";
 
+// Mock implementation of AmazonWebServiceRequest
+class MockRequest : public Aws::AmazonWebServiceRequest {
+public:
+    std::shared_ptr<Aws::IOStream> GetBody() const override { return nullptr; }
+    Aws::Http::HeaderValueCollection GetHeaders() const override { return {}; }
+    const char* GetServiceRequestName() const override { return "MockRequest"; }
+};
+
 class ChunkingInterceptorTest : public Aws::Testing::AwsCppSdkGTestSuite {
 protected:
     template <typename Fn>
@@ -36,7 +49,7 @@ TEST_F(ChunkingInterceptorTest, ChunkedStreamShouldWork) {
         char buffer[100];
         std::stringstream output;
 
-        // Read in 10-byte chunks like original test
+        // Read in 10-byte chunks
         for (int i = 0; i < 4; i++) {
             chunkedStream.read(buffer, 10);
             auto bytesRead = chunkedStream.gcount();
@@ -100,4 +113,50 @@ TEST_F(ChunkingInterceptorTest, ShouldWorkOnEmptyStream) {
         std::string output(buffer, bytesRead);
         EXPECT_EQ("0\r\nx-amz-checksum-crc32:AAAAAA==\r\n\r\n", output);
     });
+}
+
+// Custom HTTP client (inherits default IsDefaultAwsHttpClient() = false from base class)
+class CustomHttpClient : public Aws::Http::HttpClient {
+public:
+    std::shared_ptr<Aws::Http::HttpResponse> MakeRequest(const std::shared_ptr<Aws::Http::HttpRequest>&, 
+                                                        Aws::Utils::RateLimits::RateLimiterInterface*, 
+                                                        Aws::Utils::RateLimits::RateLimiterInterface*) const override {
+        return nullptr;
+    }
+};
+
+TEST_F(ChunkingInterceptorTest, ShouldNotApplyChunkingForCustomHttpClient) {
+    // Simulate the GetChunkingConfig behavior from AWSClient.cpp
+    // When IsDefaultAwsHttpClient() returns false, httpClientChunkedMode is set to CLIENT_IMPLEMENTATION
+    Aws::Client::ClientConfiguration config;
+    auto customHttpClient = Aws::MakeShared<CustomHttpClient>(CHUNKING_TEST_LOG_TAG);
+    
+    // This simulates the logic in GetChunkingConfig function
+    if (!customHttpClient->IsDefaultAwsHttpClient()) {
+        config.httpClientChunkedMode = Aws::Client::HttpClientChunkedMode::CLIENT_IMPLEMENTATION;
+    }
+    
+    ChunkingInterceptor interceptor(config);
+    
+    // Create request with checksum (would normally trigger chunking)
+    auto request = Aws::MakeShared<StandardHttpRequest>(CHUNKING_TEST_LOG_TAG, "test.com", Http::HttpMethod::HTTP_POST);
+    auto requestHash = Aws::MakeShared<CRC32>(CHUNKING_TEST_LOG_TAG);
+    request->SetRequestHash("crc32", requestHash);
+    
+    auto inputStream = Aws::MakeShared<Aws::StringStream>(CHUNKING_TEST_LOG_TAG);
+    *inputStream << "test data";
+    request->AddContentBody(inputStream);
+    
+    // Create interceptor context with a mock request
+    MockRequest mockRequest;
+    smithy::interceptor::InterceptorContext context(mockRequest);
+    context.SetTransmitRequest(request);
+    
+    // Apply interceptor
+    auto result = interceptor.ModifyBeforeSigning(context);
+    
+    // Verify chunking was NOT applied because custom HTTP client uses default IsDefaultAwsHttpClient() = false
+    EXPECT_EQ(request, result.GetResult());
+    EXPECT_FALSE(request->HasHeader(Aws::Http::AWS_TRAILER_HEADER));
+    EXPECT_FALSE(request->HasHeader(Aws::Http::TRANSFER_ENCODING_HEADER));
 }