Skip to content

Commit 812cede

Browse files
sliedigsliedig
committed
refactor: renames ApprovalService to PublicationManagerService for handling publication approval requests and events
1 parent 8bde59d commit 812cede

9 files changed

Lines changed: 17 additions & 11 deletions

File tree

‎pyproject.toml‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
[project]
2+
name = "aws-serverless-developer-experience-workshop-python"
3+
version = "0.1.0"
4+
description = "Add your description here"
5+
requires-python = ">=3.12"
6+
dependencies = []

‎unicorn_approvals/template.yaml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ Resources:
9595
Type: AWS::Serverless::Function
9696
Properties:
9797
CodeUri: src/
98-
Handler: approvals_service.contract_status_changed_event_handler.lambda_handler
98+
Handler: publication_manager_service.contract_status_changed_event_handler.lambda_handler
9999
Policies:
100100
- DynamoDBWritePolicy:
101101
TableName: !Ref ContractStatusTable
@@ -137,7 +137,7 @@ Resources:
137137
Type: AWS::Serverless::Function
138138
Properties:
139139
CodeUri: src/
140-
Handler: approvals_service.properties_approval_sync_function.lambda_handler
140+
Handler: publication_manager_service.properties_approval_sync_function.lambda_handler
141141
Policies:
142142
- DynamoDBReadPolicy:
143143
TableName: !Ref ContractStatusTable
@@ -184,7 +184,7 @@ Resources:
184184
Type: AWS::Serverless::Function
185185
Properties:
186186
CodeUri: src/
187-
Handler: approvals_service.wait_for_contract_approval_function.lambda_handler
187+
Handler: publication_manager_service.wait_for_contract_approval_function.lambda_handler
188188
Policies:
189189
- DynamoDBCrudPolicy:
190190
TableName: !Ref ContractStatusTable

‎unicorn_approvals/tests/unit/test_properties_approval_sync_function.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ def test_handle_status_changed_approved(caplog, stepfunction, lambda_context):
2727
pass
2828
# ddbstream_event = load_event('ddb_stream_events/status_approved_waiting_for_approval')
2929

30-
# from approvals_service import properties_approval_sync_function
30+
# from publication_manager_service import properties_approval_sync_function
3131
# reload(properties_approval_sync_function)
3232

3333
# ret = properties_approval_sync_function.lambda_handler(ddbstream_event, lambda_context)

unicorn_web/src/approvals_service/__init__.py renamed to unicorn_web/src/publication_manager_service/__init__.py

File renamed without changes.

unicorn_web/src/approvals_service/publication_approved_event_handler.py renamed to unicorn_web/src/publication_manager_service/publication_approved_event_handler.py

File renamed without changes.

unicorn_web/src/approvals_service/request_approval_function.py renamed to unicorn_web/src/publication_manager_service/request_approval_function.py

File renamed without changes.

‎unicorn_web/template.yaml‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ Resources:
111111
Type: AWS::Serverless::Function
112112
Properties:
113113
CodeUri: src/
114-
Handler: approvals_service.request_approval_function.lambda_handler
114+
Handler: publication_manager_service.request_approval_function.lambda_handler
115115
Policies:
116116
- EventBridgePutEventsPolicy:
117117
EventBusName: !Ref UnicornWebEventBus
@@ -141,7 +141,7 @@ Resources:
141141
Type: AWS::Serverless::Function
142142
Properties:
143143
CodeUri: src/
144-
Handler: approvals_service.publication_approved_event_handler.lambda_handler
144+
Handler: publication_manager_service.publication_approved_event_handler.lambda_handler
145145
Policies:
146146
- DynamoDBCrudPolicy:
147147
TableName: !Ref WebTable

‎unicorn_web/tests/unit/test_publication_approved_event_handler.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
# eventbridge_event = load_event('events/property_approved.json')
2525
# property_id = eventbridge_event['detail']['property_id']
2626

27-
# import approvals_service.publication_approved_event_handler as app
27+
# import publication_manager_service.publication_approved_event_handler as app
2828
# reload(app) # Reload is required to prevent function setup reuse from another test
2929

3030
# create_ddb_table_property_web(dynamodb)

‎unicorn_web/tests/unit/test_request_approval_function.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def test_valid_event(dynamodb, eventbridge, sqs, lambda_context):
5858
# apigw_event = load_event('events/request_approval_bad_input.json')
5959

6060
# # Loading function here so that mocking works correctly.
61-
# import approvals_service.request_approval_function as app
61+
# import publication_manager_service.request_approval_function as app
6262

6363
# # Reload is required to prevent function setup reuse from another test
6464
# reload(app)
@@ -79,7 +79,7 @@ def test_valid_event(dynamodb, eventbridge, sqs, lambda_context):
7979
# apigw_event = load_event('events/request_invalid_property_id.json')
8080

8181
# # Loading function here so that mocking works correctly.
82-
# import approvals_service.request_approval_function as app
82+
# import publication_manager_service.request_approval_function as app
8383

8484
# # Reload is required to prevent function setup reuse from another test
8585
# reload(app)
@@ -100,7 +100,7 @@ def test_valid_event(dynamodb, eventbridge, sqs, lambda_context):
100100
# apigw_event = load_event('events/request_already_approved.json')
101101

102102
# # Loading function here so that mocking works correctly.
103-
# import approvals_service.request_approval_function as app
103+
# import publication_manager_service.request_approval_function as app
104104

105105
# # Reload is required to prevent function setup reuse from another test
106106
# reload(app)
@@ -121,7 +121,7 @@ def test_valid_event(dynamodb, eventbridge, sqs, lambda_context):
121121
# apigw_event = load_event('events/request_non_existent_property.json')
122122

123123
# # Loading function here so that mocking works correctly.
124-
# import approvals_service.request_approval_function as app
124+
# import publication_manager_service.request_approval_function as app
125125

126126
# # Reload is required to prevent function setup reuse from another test
127127
# reload(app)

0 commit comments

Comments
 (0)