Expose close() on clients#336
Open
ivanauth wants to merge 1 commit into
Open
Conversation
Adds a public close() method to the v1 and materialize/v0 Client, SyncClient, and AsyncClient classes. SyncClient.close() shuts the underlying grpc.Channel synchronously; AsyncClient.close(grace=None) is a coroutine that awaits grpc.aio.Channel.close(grace). The auto-detecting Client returns whichever the active channel produces, so callers can use the same shape in both modes. Lets applications deterministically tear down connections during graceful shutdown, credential rotation, or recovery from stale connections, rather than relying on garbage collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
close()toClient,SyncClient, andAsyncClient(for both v1 and materialize/v0) so applications can deterministically release the underlying gRPC channel during graceful shutdown, credential rotation, or stale-connection recovery, rather than relying on garbage collection.Closes #314