This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
add shouldn't be ignored when already disposed #49
It seems dangerous for a
CompositeDisposableto do nothing if another disposable is added after theCompositeDisposablehas been disposed.For instance, Nuclide's
UniversalDisposableimmediately throws if it's been disposed of itself, and RxJS's Subscription immediatelyunsubscribes from the passed subscription.
Throwing seems like a pretty good option in my opinion as I can't think of a good reason to add to an already disposed composite disposable, but maybe there is?