Select to matched bracket

[lloeki]

Ctrl-M places the cursor to a bracket according to some rule. Ctrl-Shift-M should smartly† select from the current cursor position to the new one.

† This is very useful for indenting blocks, changing function arguments, modifying array/dict/hash indices or content... so best judgement must be used to set the selection properly. E.g calling it twice in a row from anywhere inside a bracketed array or parens should select whatever the inside of the brackets is. Calling it a third time could grow the selection to include the brackets.

Inspiration: vim's ci[/di[/ca[/da[

[kevinsawicki]

I really like this idea, unfortunately the cmd-shift-m keybinding is in use by the markdown-preview package, any other ideas for a keybinding to use?

[lloeki]

There are not much brackets in markdown, and the keybinding is active only in Markdown documents.

Also other keybindings would really make no sense: when "action" does a movement, people reasonably usually (i.e. about 297% of the time) expect "Shift+action" to move and select.

I think we can talk with the Markdown folks about this, and at best have them move their keybinding to Cmd+Alt+M, at worst keep the status quo and have people resolve the issue in their config file. It's not like it's unexpected to have conflicting keybindings across plugins, especially ones that make sense in a very specific context (such as Markdown preview).

[kevinsawicki]

I added this feature but bound it to ctrl-cmd-m to start with to no conflict, it will be included in the 0.85.0 release. We can discuss changing keybindings in a different PR/issue, I definitely see your point though about ctrl-shift-m being the expected keybinding for this action.

[dmnd]

I tried to use the ctrl-shift-m bind and since it didn't work I opened up Sublime instead. Then when I went to file a bug I found this had already been discussed. Consider this comment another vote that ctrl-shift-m should belong to this command, not the markdown previewer.

[scttnlsn]

@lloeki originally mentioned that repeatedly hitting ctrl-cmd-m should grow the selection. @kevinsawicki, is this implemented? I'd love to be able to hit ctrl-cmd-m twice to select everything inside and including the brackets.

[kevinsawicki]

is this implemented? I'd love to be able to hit ctrl-cmd-m twice to select everything inside and including the brackets.

Growing isn't implemented currently, mind creating a new issue for it?

[brunetton]

Referenced in #124

[brunetton]

Referenced in atom/markdown-preview#249

[brunetton]

While waiting for the pull request to be included on next Atom release, we can customize our keymap.cson adding this :

'atom-text-editor':
  'ctrl-shift-m': 'bracket-matcher:select-inside-brackets'
'atom-text-editor[data-grammar="source gfm"]':
  'ctrl-shift-m': 'markdown-preview:toggle'