Skip to content

Dev #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amirshamaei wants to merge 187 commits into
base: dev
Choose a base branch
from
Open

Dev #658

amirshamaei wants to merge 187 commits into from

Conversation

@amirshamaei
Copy link

@amirshamaei amirshamaei commented Jan 19, 2025 •
edited
Loading

What does this PR do?

Fixes #<issue_number>

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

ashleve and others added 30 commits May 2, 2023 22:04
@ashleve
Merge release 2.0.2 ashleve#573
8886a13
@tesfaldet
Lightning + Aim dependency fix in conda environment.yaml and setup.py. (
467a974 
ashleve#575)
@tesfaldet
Change "pytorch_lightning" to "lightning" in instantiators.py (ashlev…
ca07865 
…e#577)
@dreaquil
Fix WandB config improper hierarchical display of keys (ashleve#583)
9355a5d
@tesfaldet
Remove yaml extension from hydra defaults lists (ashleve#584)
b987605
@tesfaldet
Docstrings revamp (ashleve#589)
e70291d
@ashleve
Rename pyrootutils to rootutils (ashleve#592)
21313a9
@tesfaldet
Fix .log being saved in project root dir instead of log dir (ashlev…
8055898 
…e#588)
@caplett
Fix accelerator in tests/test_train.py (ashleve#595)
271972c
@amorehead
Update Lightning DDP documentation links in README.md (ashleve#601)
429947f
@tesfaldet
Fix torch.compile on nn.module instead of on LightningModule (a…
2654bad 
…shleve#587)
@amorehead
Update function arguments typing (ashleve#603)
07ce4b7
@tesfaldet
DDP-related improvements to datamodule and logging (ashleve#594)
1fb5405 
* Dividing batch size by number of devices in MNISTDataModule's setup fn
* .log file is now the same across devices when training in a DDP setting
* Adding rank-aware pylogger
@amorehead
Add FSDP support to MNISTLitModule (ashleve#604)
bddbc24
@amirshamaei
++ first try to implement Natalia's code for reconstruction was succe…
7347707 
…ssful

to do: I have to change the name from MRI to Natalia's proposed name
@amirshamaei
++ readme.md was updated
0ce5f16
@amirshamaei
++ direct toolkit was added
b374175
@amirshamaei
++ change requirements
4106af9
@amirshamaei
++ change requirements
58a91d0
@amirshamaei
++ add experiment_linux.yaml
cd16e0a 
++ add experiment_wins.yaml
++ make loss in mri_module.py
@amirshamaei
++ experiment_linux.yaml changed to cpu
46cb1c8
@amirshamaei
++ add masks to git
c6360ea
@amirshamaei
++ experiment_linux.yaml got changed
058f6d9
@amirshamaei
++ experiment_linux.yaml got changed
3329ce4 
++ wanb was added to requirements.txt
@amirshamaei
++ .to('cuda') is removed from natalia's code, so runs on cpu
38c21bd
@amirshamaei
++ nothing important
6577dfa
@amirshamaei
++ nothing important
06b8837
@amirshamaei
++ nothing important
83e7e69
@amirshamaei
++ nothing important
7068faa
@amirshamaei
++ testing ddp
5602fe2
amirshamaei and others added 24 commits February 20, 2024 12:15
@amirshamaei
+ with stable diffusion
4422ef1
@amirshamaei
Merge branch 'main' of https://github.com/amirshamaei/MRI_REC_template
846917a 
merge
@amirshamaei
+ 2d vs 3d roberto
b0df756
@amirshamaei
Merge branch 'main' of https://github.com/amirshamaei/MRI_REC_template
3a4730d 
3d
@amirshamaei
with_DiT
12bc0c7
@amirshamaei
with_DiT
50c24c7
@amirshamaei
+ with DiT 3d
757f9a3
@amirshamaei
+ with DiT 3d
afa25e4
@amirshamaei
dit_outperformed
439cf8e
@amirshamaei
large update with baysian
1e9a516
@amirshamaei
update_on_Arc
cccf71f
@amirshamaei
++ add experiment for windows
f9b01af 
+ modify bayes model
from narval
d5c4f9a
@amirshamaei
++ add experiment for windows
e2db6fa 
+ modify bayes model
@amirshamaei
++ add noise transform
fc7e1c2
@amirshamaei
++ add affine transform
7a1776e
@amirshamaei
++ add elastic deformation
4ed202a
from narval after getting results
dd0e702
@amirshamaei
++ add mcdo for narval
94efdba
some small changes in mcdo
5cf6d54
@amirshamaei
MCDO_RESULTS
0c9fe25
@amirshamaei
update gitignore from arc
8993eec
@amirshamaei
++ first try of synthRec
506c309
@amirshamaei
Update mri_calgary_campinas_module_mv.py
104a269
@amirshamaei
Copy link
Author

amirshamaei commented Jan 19, 2025

some change to print time of recon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@amirshamaei @ashleve @tesfaldet @dreaquil @caplett @amorehead