Granule List filter for dataset searches#2581
Draft
tylercchase wants to merge 6 commits into
Draft
Conversation
tylercchase
commented
May 21, 2026
| return null; | ||
| }); | ||
| }); | ||
| constructor() { |
Member
Author
There was a problem hiding this comment.
I'm still not sure whether or not to use effects in constructors. I've been seeing some people use effects by defining them as a property of the class, and that still gets the context for destruction like the constructor. Which I think I like better than doing these in the constructor or ngOnInit and passing context in but need to think about it more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Granule Listfilter