-
Notifications
You must be signed in to change notification settings - Fork 4
Support unit tag #190
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or requeststandard-complianceMissing feature required to meet fully compliance with the ASDF standardMissing feature required to meet fully compliance with the ASDF standard
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requeststandard-complianceMissing feature required to meet fully compliance with the ASDF standardMissing feature required to meet fully compliance with the ASDF standard
Type
Fields
Give feedbackNo fields configured for Feature.
The core library should support the unit tag: https://www.asdf-format.org/projects/asdf-standard/en/latest/generated/stsci.edu/asdf/unit/unit-1.0.0.html
For now no effort is made to parse or do anything with the unit strings. But it should be possible to serialize/deserialize them without losing any information, which is definitely needed for the transforms / frames in the libasdf-gwcs plugin. In principle one can simply deserialize them to strings, and then explicitly add the !unit-x.y.z tag to those strings when re-serializing. But it would be good to have a type that explicitly holds an ASDF unit.