-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Summary
As "an API user"
I want "to filter resources by labels"
So that "i can manage my resources more efficiently"
Context
Label selectors are currently not supported but should be pretty easy to implement.
control-api/apiserver/secretstorage/storage.go
Lines 161 to 169 in 72c593a
| if err := s.client.List(ctx, rsl, &client.ListOptions{ | |
| // TODO(swi): Should we add labels to the secret so we can filter on them? | |
| // Those would need to be hashed to not introduce collisions with controllers tracking state through labels like argocd does. | |
| // LabelSelector: nil, | |
| // FieldSelector: nil, | |
| Namespace: s.getBackingNamespace(), | |
| Limit: options.Limit, | |
| Continue: options.Continue, | |
| }); err != nil { |
Out of Scope
No response
Further links
No response
Acceptance Criteria
- Label filters
kubectl get -l blub=blobworks - Labels on the secret don't collide with argocd and co (hashed or moved elsewhere)
Implementation Ideas
Hash labels and add them to the secret. On list and watch calls hash the label and pass them to the backing secret list and watch.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request