Skip to content

Commit 4e752ea

Browse files
refactor: resource pmsi changes (#16)
* refactor: remove Claim resource * refactor: change Condition event date to onsetDateTime
1 parent 8436a1b commit 4e752ea

7 files changed

Lines changed: 3 additions & 21 deletions

File tree

src/main/scala/fr/aphp/id/eds/requester/jobs/SparkJobParameter.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ object JobType extends Enumeration {
3535

3636
object ResourceType extends Enumeration {
3737
type ResourceType = String
38-
val claim = "Claim"
3938
val condition = "Condition"
4039
val documentReference = "DocumentReference"
4140
val encounter = "Encounter"
@@ -48,7 +47,6 @@ object ResourceType extends Enumeration {
4847
val questionnaireResponse = "QuestionnaireResponse"
4948

5049
val all: Seq[ResourceType] = Seq(
51-
claim,
5250
condition,
5351
documentReference,
5452
encounter,

src/main/scala/fr/aphp/id/eds/requester/query/engine/QueryBuilderUtils.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ object QueryBuilderUtils {
4848
QueryColumn.ENCOUNTER_START_DATE,
4949
QueryColumn.ENCOUNTER_END_DATE),
5050
FhirResource.GROUP -> List(),
51-
FhirResource.CLAIM -> List(QueryColumn.ENCOUNTER_END_DATE,
52-
QueryColumn.ENCOUNTER_START_DATE,
53-
EVENT_DATE),
5451
FhirResource.PROCEDURE -> List(EVENT_DATE,
5552
QueryColumn.ENCOUNTER_END_DATE,
5653
QueryColumn.ENCOUNTER_START_DATE),

src/main/scala/fr/aphp/id/eds/requester/query/resolver/rest/RestFhirQueryElementsConfig.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ class RestFhirQueryElementsConfig extends ResourceConfig {
4949
defaultResourceMapping(Some("subject"), Some("encounter"), Some("effectivePeriod.start"), codeColumn = Some("medicationCodeableConcept.coding.code"))),
5050
FhirResource.DOCUMENT_REFERENCE -> addJoinedResourceColumns(
5151
defaultResourceMapping(Some("subject"), Some("encounter"), Some("date"))),
52-
FhirResource.CLAIM -> addJoinedResourceColumns(
53-
defaultResourceMapping(Some("subject"), Some("encounter"), Some("created"), codeColumn = Some("diagnosis.diagnosisCodeableConcept.coding.code"))),
5452
FhirResource.PROCEDURE -> addJoinedResourceColumns(
5553
defaultResourceMapping(Some("subject"), Some("encounter"), Some("date"), codeColumn = Some("code.coding.code"))),
5654
FhirResource.IMAGING_STUDY -> addJoinedResourceColumns(

src/main/scala/fr/aphp/id/eds/requester/query/resolver/solr/SolrQueryElementsConfig.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,6 @@ class SolrQueryElementsConfig extends ResourceConfig {
5353
FhirResource.COMPOSITION -> buildDefaultMap(List(SolrColumn.Document.DATE)),
5454
FhirResource.GROUP -> Map(QueryColumn.PATIENT -> List(SolrColumn.Group.RESOURCE_ID),
5555
QueryColumn.ID -> List(SolrColumn.ID)),
56-
FhirResource.CLAIM -> buildDefaultMap(List(SolrColumn.Claim.CREATED),
57-
codeCol = Some(List(SolrColumn.Claim.CODE))
58-
),
5956
FhirResource.PROCEDURE -> buildDefaultMap(List(SolrColumn.Procedure.DATE),
6057
codeCol = Some(List(SolrColumn.Procedure.CODE))
6158
),

src/main/scala/fr/aphp/id/eds/requester/query/resolver/solr/SolrQueryResolver.scala

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class SolrQueryResolver(solrSparkReader: SolrSparkReader,
4949
if (codeColumns.nonEmpty) {
5050
criterionDataFrame = criterionDataFrame.withColumn(
5151
QueryColumn.CODE,
52-
array_join(array(codeColumns.map((c) => col(s"`${c}`")): _*), ",")
52+
array_join(array(codeColumns.map(c => col(s"`$c`")): _*), ",")
5353
)
5454
}
5555
}
@@ -79,7 +79,7 @@ class SolrQueryResolver(solrSparkReader: SolrSparkReader,
7979
return ""
8080
}
8181
val list = sourcePopulation.cohortList.get.map(x => x.toString).mkString(" ")
82-
s"_list:(${list}) OR ({!join from=resourceId to=_subject fromIndex=groupAphp v='groupId:(${list})' score=none method=crossCollection})"
82+
s"_list:($list) OR ({!join from=resourceId to=_subject fromIndex=groupAphp v='groupId:($list)' score=none method=crossCollection})"
8383
}
8484

8585
/**
@@ -136,7 +136,6 @@ object SolrCollections {
136136
FhirResource.CONDITION -> CONDITION_APHP,
137137
FhirResource.PROCEDURE -> PROCEDURE_APHP,
138138
FhirResource.DOCUMENT_REFERENCE -> DOCUMENTREFERENCE_APHP,
139-
FhirResource.CLAIM -> CLAIM_APHP,
140139
FhirResource.COMPOSITION -> COMPOSITION_APHP,
141140
FhirResource.GROUP -> GROUP_APHP,
142141
FhirResource.MEDICATION_REQUEST -> MEDICATIONREQUEST_APHP,

src/main/scala/fr/aphp/id/eds/requester/query/resolver/solr/package.scala

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,8 @@ package object solr {
4040
final val CODE = "code.coding.display.anabio"
4141
}
4242

43-
object Claim {
44-
final val CREATED = "created"
45-
final val CODE = "diagnosis.diagnosisCodeableConcept.coding.display"
46-
}
47-
4843
object Condition {
49-
final val RECORDED_DATE = "recordedDate"
44+
final val RECORDED_DATE = "onsetDateTime"
5045
final val CODE = "code.coding.display"
5146
}
5247

src/main/scala/fr/aphp/id/eds/requester/requester.scala

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ package object requester {
99
final val CONDITION = "Condition"
1010
final val PROCEDURE = "Procedure"
1111
final val DOCUMENT_REFERENCE = "DocumentReference"
12-
final val CLAIM = "Claim"
1312
final val COMPOSITION = "Composition"
1413
final val GROUP = "Group"
1514
final val MEDICATION_REQUEST = "MedicationRequest"
@@ -25,7 +24,6 @@ package object requester {
2524
final val CONDITION_APHP = "conditionAphp"
2625
final val PROCEDURE_APHP = "procedureAphp"
2726
final val DOCUMENTREFERENCE_APHP = "documentReferenceAphp"
28-
final val CLAIM_APHP = "claimAphp"
2927
final val COMPOSITION_APHP = "compositionAphp"
3028
final val GROUP_APHP = "groupAphp"
3129
final val MEDICATIONREQUEST_APHP = "medicationRequestAphp"

0 commit comments

Comments
 (0)