Configure mockito as an agent

[tballison]

What kind of issue is this?

• Question. This issue tracker is not the best place for questions. If you want to ask how to do
  something, or to understand why something isn't working the way you expect it to, use StackOverflow
  instead with the label 'stormcrawler': https://stackoverflow.com/questions/tagged/stormcrawler

• Bug report. If you’ve found a bug, please include a test if you can, it makes it a lot easier to fix things. Use the label 'bug' on the issue.

• [* ] Feature request. Please use the label 'wish' on the issue.

Thanks!

This is a trivial task, not really a wish.

Follow the directions here: so that we don't get error messages during the build: https://javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/Mockito.html#0.3

[rzo1]

What do we need to do here @tballison ?

[tballison]

I'm sorry. I have no idea. I just got annoyed at that error msg when building. 🤣

[dpol1]

Hi @tballison @rzo1,

I am a new contributor and I would love to pick up this good first issue!

To follow the Mockito guidelines provided in the issue description and eliminate the warning about dynamic agent loading during tests, we need to explicitly attach Mockito as a javaagent.

My plan is to update the maven-surefire-plugin configuration in the root pom.xml. Since the project already relies on <argLine> (e.g., for JaCoCo), I will safely append the Mockito agent to the existing argLine like this:

<argLine>${argLine} -javaagent:${settings.localRepository}/org/mockito/mockito-core/${mockito.version}/mockito-core-${mockito.version}.jar</argLine>

I think this approach remove the warning entirely while keeping the rest of the test suite and coverage metrics intact.

Does this implementation sound good for you?

[rzo1]

Go for it. Thx 🙃