-
Notifications
You must be signed in to change notification settings - Fork 581
HDDS-13081. Add S3 Object tagging tests #9457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Gargi-jais11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @0lai0 for the patch.
I have few more test case suggestions which could be added.
| } | ||
|
|
||
| @Test | ||
| public void testGetObjectTagging() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testPutObjectTagging()and testGetObjectTagging(), are functionally very similar and could be merged into a single test named as testPutAndGetObjectTagging().
|
More Edge Cases which can be tested:
|
Tejaskriya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @0lai0 , I second the suggestion of @Gargi-jais11 , the tests added mostly look good, but they are mainly the positive cases. Can we add tests for the error cases?
Also, multiple related test cases could be put in one test method to avoid duplication.
Yes correct @Tejaskriya above test cases can be added to check for error cases. |
What changes were proposed in this pull request?
Adding PutObjectTagging, GetObjectTagging, DeleteObjectTagging SDK integration tests to validate.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-13081