JSONLayout escaping for malformed UTF-8 input#686
Open
jmestwa-coder wants to merge 1 commit into
Open
Conversation
jmestwa-coder
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix JSONLayout escaping for malformed UTF-8 input.
Previously, malformed decoded input could bypass replacement escaping and preserve the original malformed bytes in emitted JSON output. This happened because the replacement character (
U+FFFD) incorrectly followed the printable fast path.This change ensures malformed decoded input and invalid Unicode scalar values are consistently emitted through the JSON escaping path as
\ufffd.Changes
escapeReplacementhandling inJSONLayout::appendItem()Regression Test
Added a focused regression test for malformed UTF-8 input to verify malformed bytes no longer survive into JSON output and are emitted as escaped replacement characters instead.