Reject trailing characters in StringHelper numeric parsing#665
Open
jmestwa-coder wants to merge 2 commits into
Open
Reject trailing characters in StringHelper numeric parsing#665jmestwa-coder wants to merge 2 commits into
jmestwa-coder wants to merge 2 commits into
Conversation
Contributor
|
As the failing tests show, this PR breaks existing code that expects trailing non-digits to terminate an integer. I do not believe this PR adds any value to the code base, especially given that |
Contributor
Author
|
@swebb2066 , I was treating the behavior difference as an inconsistency, but I understand now that the permissive parsing in StringHelper::toInt is intentional and relied upon by existing code paths. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve
StringHelper::toIntandStringHelper::toInt64to reject malformed numeric input with trailing non-whitespace characters instead of silently accepting partial parses.Examples of previously accepted input:
"123abc"→ parsed as123"514udp"→ parsed as514This change now requires the full numeric string to be consumed (excluding trailing whitespace).
Changes
std::stoi/std::stollLOG4CXX_ENCODE_CHARfor consistent cross-platformLogStringhandlingRationale
OptionConverter::toIntalready rejects trailing characters using full-string validation. This change alignsStringHelpernumeric parsing behavior with the existing strict parsing semantics used elsewhere in the project and avoids silently accepting malformed numeric configuration values.