fix the pyproject and build system

Author: geruh

.github/workflows/pypi-build-artifacts.yml

@@ -53,12 +53,12 @@ jobs:
       - name: Set version with RC
         env:
           VERSION: ${{ inputs.VERSION }}
-        run: python -m uv version "${{ env.VERSION }}"
+        run: uv version "${{ env.VERSION }}"
 
       # Publish the source distribution with the version that's in
       # the repository, otherwise the tests will fail
       - name: Compile source distribution
-        run: uv build --sdist --wheel
+        run: uv build --sdist
         if: startsWith(matrix.os, 'ubuntu')
 
       - name: Build wheels

.github/workflows/svn-build-artifacts.yml

@@ -53,7 +53,7 @@ jobs:
       # Publish the source distribution with the version that's in
       # the repository, otherwise the tests will fail
       - name: Compile source distribution
-        run: uv build --sdist --wheel
+        run: uv build --sdist
         if: startsWith(matrix.os, 'ubuntu')
 
       - name: Build wheels

build-module.py

@@ -18,54 +18,58 @@
 import os
 import shutil
 from pathlib import Path
+from typing import Any
 
-allowed_to_fail = os.environ.get("CIBUILDWHEEL", "0") != "1"
+from hatchling.builders.hooks.plugin.interface import BuildHookInterface
 
+allowed_to_fail = os.environ.get("CIBUILDWHEEL", "0") != "1"
 
-def build_cython_extensions() -> None:
-    import Cython.Compiler.Options
-    from Cython.Build import build_ext, cythonize
-    from setuptools import Extension
-    from setuptools.dist import Distribution
 
-    Cython.Compiler.Options.annotate = True
+class CythonBuildHook(BuildHookInterface):
+    def build_cython_extensions(self) -> None:
+        import Cython.Compiler.Options
+        from Cython.Build import build_ext, cythonize
+        from setuptools import Extension
+        from setuptools.dist import Distribution
 
-    if os.name == "nt":  # Windows
-        extra_compile_args = [
-            "/O2",
-        ]
-    else:  # UNIX-based systems
-        extra_compile_args = [
-            "-O3",
-        ]
+        Cython.Compiler.Options.annotate = True
 
-    package_path = "pyiceberg"
+        if os.name == "nt":  # Windows
+            extra_compile_args = [
+                "/O2",
+            ]
+        else:  # UNIX-based systems
+            extra_compile_args = [
+                "-O3",
+            ]
 
-    extension = Extension(
-        # Your .pyx file will be available to cpython at this location.
-        name="pyiceberg.avro.decoder_fast",
-        sources=[
-            os.path.join(package_path, "avro", "decoder_fast.pyx"),
-        ],
-        extra_compile_args=extra_compile_args,
-        language="c",
-    )
+        package_path = "pyiceberg"
 
-    ext_modules = cythonize([extension], include_path=list(package_path), language_level=3, annotate=True)
-    dist = Distribution({"ext_modules": ext_modules})
-    cmd = build_ext(dist)
-    cmd.ensure_finalized()
+        extension = Extension(
+            # Your .pyx file will be available to cpython at this location.
+            name="pyiceberg.avro.decoder_fast",
+            sources=[
+                os.path.join(package_path, "avro", "decoder_fast.pyx"),
+            ],
+            extra_compile_args=extra_compile_args,
+            language="c",
+        )
 
-    cmd.run()
+        ext_modules = cythonize([extension], include_path=list(package_path), language_level=3, annotate=True)
+        dist = Distribution({"ext_modules": ext_modules})
+        cmd = build_ext(dist)
+        cmd.ensure_finalized()
 
-    for output in cmd.get_outputs():
-        output = Path(output)
-        relative_extension = output.relative_to(cmd.build_lib)
-        shutil.copyfile(output, relative_extension)
+        cmd.run()
 
+        for output in cmd.get_outputs():
+            output = Path(output)
+            relative_extension = output.relative_to(cmd.build_lib)
+            shutil.copyfile(output, relative_extension)
 
-try:
-    build_cython_extensions()
-except Exception:
-    if not allowed_to_fail:
-        raise
+    def initialize(self, version: str, build_data: dict[str, Any]) -> None:
+        try:
+            self.build_cython_extensions()
+        except Exception:
+            if not allowed_to_fail:
+                raise

pyproject.toml

@@ -36,13 +36,14 @@ dependencies = [
     "click>=7.1.1,<9.0.0",
     "rich>=10.11.0,<15.0.0",
     "strictyaml>=1.7.0,<2.0.0", # CVE-2020-14343 was fixed in 5.4.
-    "pydantic>=2.0,<3.0,!=2.4.0,!=2.4.1,<2.12.0", # 2.4.0, 2.4.1, 2.12.0 has a critical bug
+    "pydantic>=2.0,!=2.4.0,!=2.4.1,<2.12.0", # 2.4.0, 2.4.1, 2.12.0 has a critical bug
     "sortedcontainers==2.4.0",
     "fsspec>=2023.1.0",
     "pyparsing>=3.1.0,<4.0.0",
     "tenacity>=8.2.3,<10.0.0",
     "pyroaring>=1.0.0,<2.0.0",
     "cachetools>=5.5,<7.0",
+    "zstandard>=0.13.0,<1.0.0"
 ]
 
 [project.optional-dependencies]
@@ -78,7 +79,6 @@ glue = ["boto3>=1.24.59"]
 adlfs = ["adlfs>=2024.7.0"]
 dynamodb = ["boto3>=1.24.59"]
 bigquery = ["google-cloud-bigquery>=3.33.0,<4"]
-zstandard = ["zstandard>=0.13.0,<1.0.0"]
 sql-postgres = [
     "sqlalchemy>=2.0.18,<3",
     "psycopg2-binary>=2.9.6",
@@ -148,7 +148,7 @@ include = [
     "Makefile",
     "NOTICE",
     "dev",
-    "uv.lock",
+    "build-module.py"
 ]
 
 [tool.hatch.build.targets.wheel]
@@ -165,8 +165,11 @@ include = [
 "vendor/fb303" = "fb303"
 "vendor/hive_metastore" = "hive_metastore"
 
+[tool.hatch.build.hooks.custom]
+path = "build-module.py"
+
 [build-system]
-requires = ["hatchling"]
+requires = ["hatchling", "Cython>=3.0.0", "setuptools", "wheel"]
 build-backend = "hatchling.build"
 
 [[tool.mypy.overrides]]
@@ -329,6 +332,10 @@ ignore_missing_imports = true
 module = "setuptools.*"
 ignore_missing_imports = true
 
+[[tool.mypy.overrides]]
+module = "hatchling.*"
+ignore_missing_imports = true
+
 [[tool.mypy.overrides]]
 module = "tenacity.*"
 ignore_missing_imports = true