Remove sortedcontainers dependency (#2947)

closes #2945 

# Rationale for this change

This PR removes the `SortedContainers` dependency. Looking at the
behavior of sorted containers we can simplify the logic for merging
manigests and collecting the results while maintaining identical
behavior.

**What the logic today was doing:**
1. Submit all manifest merge tasks to thread pool (pallelism starts with
executor)
2. Collect futures as they complete using `as_completed()` which is out
of order
3. Store completed futures in a `SortedList` to maintain order by
submission
4. Extract all results from the sorted futures
5. Flatten and return

**What we do now:**
1. Submit all manifest merge tasks to thread pool (pallelism starts with
executor)
2. Iterate through futures in submission order, calling `.result()` on
each
3. Flatten and return

This shows we must collect the results before the next step. So we can
iterate futures directly and call `.result()` in order. This blocks the
main thread until each future completes, but doesn't block worker
threads and they all continue running in parallel.

## Are these changes tested?

All existing tests pass.

## Are there any user-facing changes?

No

Author: geruh

pyiceberg/table/update/snapshot.py

@@ -16,19 +16,15 @@
 # under the License.
 from __future__ import annotations
 
-import concurrent.futures
 import itertools
 import uuid
 from abc import abstractmethod
 from collections import defaultdict
 from collections.abc import Callable
-from concurrent.futures import Future
 from datetime import datetime
 from functools import cached_property
 from typing import TYPE_CHECKING, Generic
 
-from sortedcontainers import SortedList
-
 from pyiceberg.avro.codecs import AvroCompressionCodec
 from pyiceberg.expressions import (
     AlwaysFalse,
@@ -792,14 +788,7 @@ def merge_bin(manifest_bin: list[ManifestFile]) -> list[ManifestFile]:
 
         executor = ExecutorFactory.get_or_create()
         futures = [executor.submit(merge_bin, b) for b in bins]
-
-        # for consistent ordering, we need to maintain future order
-        futures_index = {f: i for i, f in enumerate(futures)}
-        completed_futures: SortedList[Future[list[ManifestFile]]] = SortedList(iterable=[], key=lambda f: futures_index[f])
-        for future in concurrent.futures.as_completed(futures):
-            completed_futures.add(future)
-
-        bin_results: list[list[ManifestFile]] = [f.result() for f in completed_futures if f.result()]
+        bin_results: list[list[ManifestFile]] = [r for f in futures if (r := f.result())]
 
         return [manifest for bin_result in bin_results for manifest in bin_result]
 

pyproject.toml

@@ -37,7 +37,6 @@ dependencies = [
     "rich>=10.11.0,<15.0.0",
     "strictyaml>=1.7.0,<2.0.0", # CVE-2020-14343 was fixed in 5.4.
     "pydantic>=2.0,<3.0,!=2.4.0,!=2.4.1,!=2.12.0,!=2.12.1", # 2.4.0, 2.4.1, 2.12.0, 2.12.1 has a critical bug
-    "sortedcontainers==2.4.0",
     "fsspec>=2023.1.0",
     "pyparsing>=3.1.0,<4.0.0",
     "tenacity>=8.2.3,<10.0.0",