chore: remove spdlog dependency (#459)

We are not currently using spdlog, so the dependency can be removed. It
can be added back when it is actually needed.

Author: zhjwpku

README.md

@@ -43,7 +43,6 @@ The following environment variables can be set to customize dependency URLs:
 - `ICEBERG_NANOARROW_URL`: Nanoarrow tarball URL
 - `ICEBERG_CROARING_URL`: CRoaring tarball URL
 - `ICEBERG_NLOHMANN_JSON_URL`: nlohmann-json tarball URL
-- `ICEBERG_SPDLOG_URL`: spdlog tarball URL
 - `ICEBERG_CPR_URL`: cpr tarball URL
 
 Example usage:

cmake_modules/IcebergThirdpartyToolchain.cmake

@@ -31,7 +31,6 @@ set(ICEBERG_ARROW_INSTALL_INTERFACE_LIBS)
 # ICEBERG_NANOARROW_URL      - Nanoarrow tarball URL
 # ICEBERG_CROARING_URL       - CRoaring tarball URL
 # ICEBERG_NLOHMANN_JSON_URL  - nlohmann-json tarball URL
-# ICEBERG_SPDLOG_URL         - spdlog tarball URL
 # ICEBERG_CPR_URL            - cpr tarball URL
 #
 # Example usage:
@@ -427,61 +426,6 @@ function(resolve_nlohmann_json_dependency)
       PARENT_SCOPE)
 endfunction()
 
-# ----------------------------------------------------------------------
-# spdlog
-
-function(resolve_spdlog_dependency)
-  prepare_fetchcontent()
-
-  find_package(Threads REQUIRED)
-
-  set(SPDLOG_USE_STD_FORMAT
-      ON
-      CACHE BOOL "" FORCE)
-  set(SPDLOG_BUILD_PIC
-      ON
-      CACHE BOOL "" FORCE)
-
-  if(DEFINED ENV{ICEBERG_SPDLOG_URL})
-    set(SPDLOG_URL "$ENV{ICEBERG_SPDLOG_URL}")
-  else()
-    set(SPDLOG_URL "https://github.com/gabime/spdlog/archive/refs/tags/v1.15.3.tar.gz")
-  endif()
-
-  fetchcontent_declare(spdlog
-                       ${FC_DECLARE_COMMON_OPTIONS}
-                       URL ${SPDLOG_URL}
-                           FIND_PACKAGE_ARGS
-                           NAMES
-                           spdlog
-                           CONFIG)
-  fetchcontent_makeavailable(spdlog)
-
-  if(spdlog_SOURCE_DIR)
-    set_target_properties(spdlog PROPERTIES OUTPUT_NAME "iceberg_vendored_spdlog"
-                                            POSITION_INDEPENDENT_CODE ON)
-    target_link_libraries(spdlog INTERFACE Threads::Threads)
-    install(TARGETS spdlog
-            EXPORT iceberg_targets
-            RUNTIME DESTINATION "${ICEBERG_INSTALL_BINDIR}"
-            ARCHIVE DESTINATION "${ICEBERG_INSTALL_LIBDIR}"
-            LIBRARY DESTINATION "${ICEBERG_INSTALL_LIBDIR}")
-    set(SPDLOG_VENDORED TRUE)
-  else()
-    set(SPDLOG_VENDORED FALSE)
-    list(APPEND ICEBERG_SYSTEM_DEPENDENCIES spdlog)
-  endif()
-
-  list(APPEND ICEBERG_SYSTEM_DEPENDENCIES Threads)
-
-  set(ICEBERG_SYSTEM_DEPENDENCIES
-      ${ICEBERG_SYSTEM_DEPENDENCIES}
-      PARENT_SCOPE)
-  set(SPDLOG_VENDORED
-      ${SPDLOG_VENDORED}
-      PARENT_SCOPE)
-endfunction()
-
 # ----------------------------------------------------------------------
 # zlib
 
@@ -575,7 +519,6 @@ resolve_zlib_dependency()
 resolve_nanoarrow_dependency()
 resolve_croaring_dependency()
 resolve_nlohmann_json_dependency()
-resolve_spdlog_dependency()
 
 if(ICEBERG_BUILD_BUNDLE)
   resolve_arrow_dependency()

src/iceberg/CMakeLists.txt

@@ -107,27 +107,23 @@ list(APPEND
      nanoarrow::nanoarrow_static
      nlohmann_json::nlohmann_json
      roaring::roaring
-     spdlog::spdlog
      ZLIB::ZLIB)
 list(APPEND
      ICEBERG_SHARED_BUILD_INTERFACE_LIBS
      nanoarrow::nanoarrow_shared
      nlohmann_json::nlohmann_json
      roaring::roaring
-     spdlog::spdlog
      ZLIB::ZLIB)
 list(APPEND
      ICEBERG_STATIC_INSTALL_INTERFACE_LIBS
      "$<IF:$<BOOL:${NANOARROW_VENDORED}>,iceberg::nanoarrow_static,$<IF:$<TARGET_EXISTS:nanoarrow::nanoarrow_static>,nanoarrow::nanoarrow_static,nanoarrow::nanoarrow_shared>>"
      "$<IF:$<BOOL:${NLOHMANN_JSON_VENDORED}>,iceberg::nlohmann_json,$<IF:$<TARGET_EXISTS:nlohmann_json::nlohmann_json>,nlohmann_json::nlohmann_json,nlohmann_json::nlohmann_json>>"
-     "$<IF:$<BOOL:${CROARING_VENDORED}>,iceberg::roaring,roaring::roaring>"
-     "$<IF:$<BOOL:${SPDLOG_VENDORED}>,iceberg::spdlog,spdlog::spdlog>")
+     "$<IF:$<BOOL:${CROARING_VENDORED}>,iceberg::roaring,roaring::roaring>")
 list(APPEND
      ICEBERG_SHARED_INSTALL_INTERFACE_LIBS
      "$<IF:$<BOOL:${NANOARROW_VENDORED}>,iceberg::nanoarrow_shared,$<IF:$<TARGET_EXISTS:nanoarrow::nanoarrow_shared>,nanoarrow::nanoarrow_shared,nanoarrow::nanoarrow_static>>"
      "$<IF:$<BOOL:${NLOHMANN_JSON_VENDORED}>,iceberg::nlohmann_json,$<IF:$<TARGET_EXISTS:nlohmann_json::nlohmann_json>,nlohmann_json::nlohmann_json,nlohmann_json::nlohmann_json>>"
-     "$<IF:$<BOOL:${CROARING_VENDORED}>,iceberg::roaring,roaring::roaring>"
-     "$<IF:$<BOOL:${SPDLOG_VENDORED}>,iceberg::spdlog,spdlog::spdlog>")
+     "$<IF:$<BOOL:${CROARING_VENDORED}>,iceberg::roaring,roaring::roaring>")
 
 add_iceberg_lib(iceberg
                 SOURCES

src/iceberg/meson.build

@@ -128,16 +128,9 @@ croaring_needs_static = (
 croaring_dep = dependency('croaring', static: croaring_needs_static)
 nanoarrow_dep = dependency('nanoarrow')
 nlohmann_json_dep = dependency('nlohmann_json')
-spdlog_dep = dependency('spdlog')
 zlib_dep = dependency('zlib')
 
-iceberg_deps = [
-    croaring_dep,
-    nanoarrow_dep,
-    nlohmann_json_dep,
-    spdlog_dep,
-    zlib_dep,
-]
+iceberg_deps = [croaring_dep, nanoarrow_dep, nlohmann_json_dep, zlib_dep]
 
 iceberg_lib = library(
     'iceberg',