Skip to content

Commit 4c7780c

Browse files
committed
Upgrade Apache RAT
During local development, I'm regularly annoyed by spurious RAT failures. While RAT does have some limitations -- for example, because it never shells out to `git`, it can't ignore untracked files -- newer versions do have improved support for `.gitignore` files, including the global gitignore file when present at `~/.config/git/ignore` (the default location). Additionally, the default exclusions have been improved, so we no longer need quite as much manual configuration. Specific changes: 1. Bumped `apache-rat-plugin` directly to 0.17. (In the version of the Apache parent POM we are using, there is no property we can override to do this.) 2. Removed exclusions that are obsolete or covered by our defaults. 3. Changed `apache-rat:check` to only run in `:httpcore5-parent`, instead of separately validating each subproject. 4. Changed `<exclude>` to `<inputExclude>` as the former is now deprecated.
1 parent 4abea6d commit 4c7780c

File tree

1 file changed

+10
-15
lines changed

1 file changed

+10
-15
lines changed

pom.xml

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -267,28 +267,23 @@
267267
<plugin>
268268
<groupId>org.apache.rat</groupId>
269269
<artifactId>apache-rat-plugin</artifactId>
270+
<version>0.17</version>
270271
<executions>
271272
<execution>
272273
<phase>verify</phase>
274+
<inherited>false</inherited>
273275
<goals>
274276
<goal>check</goal>
275277
</goals>
276278
</execution>
277279
</executions>
278-
<configuration>
279-
<excludes>
280-
<exclude>**/.checkstyle</exclude>
281-
<exclude>**/.pmd</exclude>
282-
<exclude>**/*.iml</exclude>
283-
<exclude>**/.externalToolBuilders/**</exclude>
284-
<exclude>maven-eclipse.xml</exclude>
285-
<exclude>src/docbkx/resources/**</exclude>
286-
<exclude>src/test/resources/*.truststore</exclude>
287-
<exclude>src/test/resources/*.p12</exclude>
288-
<exclude>**/.dockerignore</exclude>
289-
<!-- Eclipse can leave some file in 'bin' when an imported project misconfigured. -->
290-
<exclude>bin/**</exclude>
291-
</excludes>
280+
<configuration combine.self="override">
281+
<excludeSubProjects>false</excludeSubProjects>
282+
<inputExcludes>
283+
<inputExclude>**/*.pem</inputExclude>
284+
<inputExclude>**/.pmd</inputExclude>
285+
<inputExclude>**/maven-eclipse.xml</inputExclude>
286+
</inputExcludes>
292287
</configuration>
293288
</plugin>
294289
</plugins>
@@ -384,4 +379,4 @@
384379
</plugins>
385380
</reporting>
386381

387-
</project>
382+
</project>

0 commit comments

Comments
 (0)