FINERACT-2510: Resolve compilation warnings in fineract-core and ensure test compatibility

git rebase --continue

Author: Ambika-Sony

fineract-core/src/main/java/org/apache/fineract/infrastructure/core/api/JsonQuery.java

@@ -25,7 +25,7 @@
 import java.time.LocalDate;
 import java.util.Arrays;
 import java.util.Map;
-import org.apache.commons.lang3.ObjectUtils;
+import java.util.Objects;
 import org.apache.commons.lang3.StringUtils;
 import org.apache.fineract.infrastructure.core.serialization.FromJsonHelper;
 import org.apache.fineract.infrastructure.security.domain.BasicPasswordEncodablePlatformUser;
@@ -240,7 +240,7 @@ public Boolean booleanObjectValueOfParameterNamed(final String parameterName) {
      */
     public boolean booleanPrimitiveValueOfParameterNamed(final String parameterName) {
         final Boolean value = this.fromApiJsonHelper.extractBooleanNamed(parameterName, this.parsedQuery);
-        return ObjectUtils.defaultIfNull(value, Boolean.FALSE);
+        return Objects.requireNonNullElse(value, Boolean.FALSE);
     }
 
     public boolean isChangeInArrayParameterNamed(final String parameterName, final String[] existingValue) {

fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/DataEnricherProcessor.java

@@ -27,13 +27,14 @@
 @Component
 public class DataEnricherProcessor {
 
-    private final List<DataEnricher<?>> enhancers;
+    private final List<DataEnricher> enhancers;
 
     @Autowired
-    public DataEnricherProcessor(Optional<List<DataEnricher<?>>> enhancers) {
+    public DataEnricherProcessor(Optional<List<DataEnricher>> enhancers) {
         this.enhancers = enhancers.orElse(new ArrayList<>());
     }
 
+    @SuppressWarnings({ "unchecked", "rawtypes" })
     public <T> T enrich(T source) {
         for (DataEnricher enhancer : enhancers) {
             if (enhancer.isDataTypeSupported(source.getClass())) {

fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/PaginationHelper.java

@@ -19,7 +19,7 @@
 package org.apache.fineract.infrastructure.core.service;
 
 import java.util.List;
-import org.apache.commons.lang3.ObjectUtils;
+import java.util.Objects;
 import org.apache.fineract.infrastructure.core.service.database.DatabaseSpecificSQLGenerator;
 import org.apache.fineract.infrastructure.core.service.database.DatabaseTypeResolver;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -62,6 +62,6 @@ public <E> Page<Long> fetchPage(JdbcTemplate jdbcTemplate, String sql, Class<Lon
         String sqlCountRows = sqlGenerator.countLastExecutedQueryResult(sql);
         Integer totalFilteredRecords = jdbcTemplate.queryForObject(sqlCountRows, Integer.class);
 
-        return new Page<>(items, ObjectUtils.defaultIfNull(totalFilteredRecords, 0));
+        return new Page<>(items, Objects.requireNonNullElse(totalFilteredRecords, 0));
     }
 }

fineract-core/src/main/java/org/apache/fineract/infrastructure/core/service/database/JavaType.java

@@ -343,6 +343,7 @@ public boolean isDefault(Object o) {
         };
     }
 
+    @SuppressWarnings("deprecation")
     public Object parse(String s, String format, Locale locale) {
         if (s == null) {
             return null;

fineract-core/src/main/java/org/apache/fineract/infrastructure/event/external/service/InternalExternalEventService.java

@@ -108,6 +108,7 @@ private List<ExternalEventResponse> convertToReadableFormat(List<ExternalEvent>
             var payLoad = method.invoke(null, byteBuffer);
             if (externalEvent.getType().equalsIgnoreCase("BulkBusinessEvent")) {
                 var methodToGetDatas = payLoad.getClass().getMethod("getDatas", (Class<?>) null);
+                @SuppressWarnings("unchecked")
                 var bulkMessages = (List<BulkMessageItemV1>) methodToGetDatas.invoke(payLoad);
                 var bulkMessagePayload = new StringBuilder();
                 for (var bulkMessage : bulkMessages) {