Skip to content

Commit 0a82d67

Browse files
timsaucerclaude
andcommitted
Add exclusion list for DataFrame methods already covered by Python API
show_limit is covered by DataFrame.show() and with_param_values is covered by SessionContext.sql(param_values=...), so neither needs separate exposure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 88ed86c commit 0a82d67

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.claude/skills/check-upstream/SKILL.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,16 @@ The user may specify an area via `$ARGUMENTS`. If no area is specified or "all"
8787
- Python API: `python/datafusion/dataframe.py` — the `DataFrame` class
8888
- Rust bindings: `crates/core/src/dataframe.rs``PyDataFrame` with `#[pymethods]`
8989

90+
**Evaluated and not requiring separate Python exposure:**
91+
- `show_limit` — already covered by `DataFrame.show()`, which provides the same functionality with a simpler API
92+
- `with_param_values` — already covered by the `param_values` argument on `SessionContext.sql()`, which accomplishes the same thing more robustly
93+
9094
**How to check:**
9195
1. Fetch the upstream DataFrame documentation page listing all methods
9296
2. Compare against methods in `python/datafusion/dataframe.py` — this is the source of truth for coverage
9397
3. The Rust bindings (`crates/core/src/dataframe.rs`) may be consulted for context, but a method is covered if it exists in the Python API
94-
4. Report only methods missing from the Python API
98+
4. Check against the "evaluated and not requiring exposure" list before flagging as a gap
99+
5. Report only methods missing from the Python API
95100

96101
### 6. SessionContext Methods
97102

0 commit comments

Comments
 (0)