[EPIC] Fully support ANSI mode

[andygrove]

What is the problem the feature request solves?

This epic is to track the work required to fully support ANSI mode in Comet.

Here are some known areas where we need to add ANSI support. This list will grow as we investigate more.

Features that Comet currently implements

• Math
  • Abs bug: ABS should only overflow in ANSI mode #464
  • UnaryMinus feat: Implement ANSI support for UnaryMinus #465
  • Round/BRound feat: Support ANSI mode for round #466
  • BinaryArithmetic
    • Add Add ANSI support for Add #536
    • Subtract Add ANSI support for Subtract #535
    • Multiply Add ANSI support for Multiply #534
    • Divide & IntegralDivide Add ANSI support for Divide and IntegralDivide #533
    • Remainder Add ANSI support for Remainder #532
• Aggregate expression overflow
  • Add ANSI support in SUM and AVG #531
• Other
  • Cast (covered in [EPIC] Spark-compatible cast / try_cast operations #286)
  • [ANSI] Include original SQL in error messages #2215

Features that Comet has not implemented yet

• Math
  • Pmod
• Date/time
  • UnixTimestamp
  • ToUnixTimestamp
  • GetTimestamp
  • ToTimestamp
  • DateAdd
  • NextDay
  • MakeDate
  • MakeTimestamp
  • DivideInterval
  • MultiplyInterval
  • MakeInterval

Describe the potential solution

No response

Additional context

No response

[dharanad]

@andygrove I'm reaching out to inquire about the current priority of this issue and to express my interest in contributing to this issue. It seems like a valuable addition to the project.

[andygrove]

Hi @dharanad. All of the issues here are important for Spark 4.0 support. Feel free to pick up any issues that are not already being worked on

[coderfender]

@andygrove Support for Add / Subtract / Multiple and Divide are now supported as part of #2136

[coderfender]

Working on SUM ANSI impl