Skip to content

Commit f6a82ee

Browse files
author
Pearl Dsilva
committed
update pool setting when modified
1 parent 40364da commit f6a82ee

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStoragePoolManager.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@ private StorageAdaptor getStorageAdaptor(StoragePoolType type) {
7272

7373
private void addStoragePool(String uuid, StoragePoolInformation pool) {
7474
synchronized (_storagePools) {
75-
if (!_storagePools.containsKey(uuid)) {
75+
// Insert on first registration; on subsequent calls (e.g. ModifyStoragePoolCommand)
76+
// overwrite when new details are present so config changes are reflected
77+
if (!_storagePools.containsKey(uuid) || MapUtils.isNotEmpty(pool.getDetails())) {
7678
_storagePools.put(uuid, pool);
7779
}
7880
}
@@ -327,6 +329,10 @@ private void updatePoolTypeIfApplicable(LibvirtStoragePool libvirtPool, KVMStora
327329
*/
328330
private void addPoolDetails(String uuid, LibvirtStoragePool pool) {
329331
StoragePoolInformation storagePoolInformation = _storagePools.get(uuid);
332+
if (storagePoolInformation == null) {
333+
logger.warn("No cached StoragePoolInformation found for pool UUID {}, pool details will not be set.", uuid);
334+
return;
335+
}
330336
Map<String, String> details = storagePoolInformation.getDetails();
331337

332338
if (MapUtils.isNotEmpty(details)) {

0 commit comments

Comments
 (0)