Skip to content

Commit e90eae9

Browse files
committed
Change format for drs imbalance to string
1 parent 89efed2 commit e90eae9

2 files changed

Lines changed: 8 additions & 4 deletions

File tree

plugins/metrics/src/main/java/org/apache/cloudstack/metrics/MetricsServiceImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -789,7 +789,7 @@ public List<ClusterMetricsResponse> listClusterMetrics(Pair<List<ClusterResponse
789789

790790
try {
791791
Double imbalance = ClusterDrsAlgorithm.getClusterImbalance(clusterId, cpuList, memoryList, null);
792-
metricsResponse.setDrsImbalance(imbalance.isNaN() ? null : imbalance);
792+
metricsResponse.setDrsImbalance(imbalance.isNaN() ? null : String.format("%.2f%%", imbalance));
793793
} catch (ConfigurationException e) {
794794
LOGGER.warn("Failed to get cluster imbalance for cluster " + clusterId, e);
795795
}

plugins/metrics/src/main/java/org/apache/cloudstack/response/ClusterMetricsResponse.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public class ClusterMetricsResponse extends ClusterResponse implements HostMetri
9696

9797
@SerializedName("drsimbalance")
9898
@Param(description = "DRS imbalance for the cluster")
99-
private Double drsImbalance;
99+
private String drsImbalance;
100100

101101
public void setState(final String allocationState, final String managedState) {
102102
this.state = allocationState;
@@ -213,7 +213,11 @@ public void setMemoryAllocatedDisableThreshold(final Long memAllocated, final Lo
213213
}
214214
}
215215

216-
public void setDrsImbalance(Double drsImbalance) {
217-
this.drsImbalance = drsImbalance;
216+
public void setDrsImbalance(String drsImbalance) {
217+
if (drsImbalance != null) {
218+
this.drsImbalance = String.format("%.2f%%", drsImbalance);
219+
} else {
220+
this.drsImbalance = null;
221+
}
218222
}
219223
}

0 commit comments

Comments
 (0)