framework/spring: throw RuntimeException when fail to start or load a module

Author: weizhouapache

framework/spring/lifecycle/src/main/java/org/apache/cloudstack/spring/lifecycle/CloudStackExtendedLifeCycle.java

@@ -74,6 +74,7 @@ public void with(ComponentLifecycle lifecycle) {
                     lifecycle.start();
                 } catch (Exception e) {
                     logger.error("Error on starting bean {} - {}", lifecycle.getName(), e.getMessage(), e);
+                    throw new CloudRuntimeException("Failed to start bean [" + lifecycle.getName() + "]", e);
                 }
 
                 if (lifecycle instanceof ManagementBean) {

framework/spring/module/src/main/java/org/apache/cloudstack/spring/module/model/impl/DefaultModuleDefinitionSet.java

@@ -116,6 +116,7 @@ public void with(ModuleDefinition def, Stack<ModuleDefinition> parents) {
                         if (logger.isDebugEnabled()) {
                             logger.debug(String.format("module start failure of module [%s] was due to: ", moduleDefinitionName), e);
                         }
+                        throw new RuntimeException(String.format("Failed to start module [%s]", moduleDefinitionName), e);
                     }
                 } catch (EmptyStackException e) {
                     logger.warn(String.format("Failed to obtain module context due to [%s]. Using root context instead.", e.getMessage()));
@@ -147,10 +148,11 @@ public void with(ModuleDefinition def, Stack<ModuleDefinition> parents) {
                         logger.debug("Failed to obtain module context: ", e);
                     }
                 } catch (BeansException e) {
-                    logger.warn(String.format("Failed to start module [%s] due to: [%s].", def.getName(), e.getMessage()));
+                    logger.warn(String.format("Failed to load module [%s] due to: [%s].", def.getName(), e.getMessage()));
                     if (logger.isDebugEnabled()) {
-                        logger.debug(String.format("module start failure of module [%s] was due to: ", def.getName()), e);
+                        logger.debug(String.format("module load failure of module [%s] was due to: ", def.getName()), e);
                     }
+                    throw new RuntimeException(String.format("Failed to load module [%s]", def.getName()), e);
                 }
             }
         });