Skip to content

Commit 4e7a0ec

Browse files
Check config 'kvm.ha.fence.on.storage.heartbeat.failure' value in zone scope before global
1 parent 4d00921 commit 4e7a0ec

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

plugins/hypervisors/kvm/src/main/java/org/apache/cloudstack/kvm/ha/KVMHostActivityChecker.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public Status getHostAgentStatus(Host host) {
123123

124124
private Status checkHostStatusWithSameHost(Host host) {
125125
Status hostStatus;
126-
boolean reportFailureIfOneStorageIsDown = HighAvailabilityManager.KvmHAFenceHostIfHeartbeatFailsOnStorage.value();
126+
boolean reportFailureIfOneStorageIsDown = HighAvailabilityManager.KvmHAFenceHostIfHeartbeatFailsOnStorage.valueIn(host.getDataCenterId());
127127
final CheckOnHostCommand cmd = new CheckOnHostCommand(host, reportFailureIfOneStorageIsDown);
128128
try {
129129
logger.debug("Checking {} status...", host.toString());
@@ -150,7 +150,7 @@ private Status checkHostStatusWithSameHost(Host host) {
150150

151151
private Status checkHostStatusWithNeighbourHosts(Host host) {
152152
Status hostStatusFromNeighbour = Status.Unknown;
153-
boolean reportFailureIfOneStorageIsDown = HighAvailabilityManager.KvmHAFenceHostIfHeartbeatFailsOnStorage.value();
153+
boolean reportFailureIfOneStorageIsDown = HighAvailabilityManager.KvmHAFenceHostIfHeartbeatFailsOnStorage.valueIn(host.getDataCenterId());
154154
final CheckOnHostCommand cmd = new CheckOnHostCommand(host, reportFailureIfOneStorageIsDown);
155155
List<HostVO> neighbors = resourceManager.listHostsInClusterByStatus(host.getClusterId(), Status.Up);
156156
for (HostVO neighbor : neighbors) {

server/src/main/java/com/cloud/ha/KVMFencer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public Boolean fenceOff(VirtualMachine vm, Host host) {
8080

8181
List<HostVO> hosts = _resourceMgr.listAllHostsInCluster(host.getClusterId());
8282
FenceCommand fence = new FenceCommand(vm, host);
83-
fence.setReportCheckFailureIfOneStorageIsDown(HighAvailabilityManager.KvmHAFenceHostIfHeartbeatFailsOnStorage.value());
83+
fence.setReportCheckFailureIfOneStorageIsDown(HighAvailabilityManager.KvmHAFenceHostIfHeartbeatFailsOnStorage.valueIn(host.getDataCenterId()));
8484

8585
int i = 0;
8686
for (HostVO h : hosts) {

0 commit comments

Comments
 (0)