Naming corrections for service offering response

Author: harikrishna-patnala

api/src/main/java/org/apache/cloudstack/api/ApiConstants.java

@@ -831,7 +831,7 @@ public class ApiConstants {
     public static final String CROSS_ZONES = "crossZones";
     public static final String TEMPLATETYPE = "templatetype";
     public static final String SOURCETEMPLATEID = "sourcetemplateid";
-    public static final String DynamicScalingEnabled = "dynamicscalingenabled";
+    public static final String DYNAMIC_SCALING_ENABLED = "dynamicscalingenabled";
 
     public enum BootType {
         UEFI, BIOS;

api/src/main/java/org/apache/cloudstack/api/command/admin/offering/CreateServiceOfferingCmd.java

@@ -223,7 +223,7 @@ public class CreateServiceOfferingCmd extends BaseCmd {
     @Parameter(name = ApiConstants.STORAGE_POLICY, type = CommandType.UUID, entityType = VsphereStoragePoliciesResponse.class,required = false, description = "Name of the storage policy defined at vCenter, this is applicable only for VMware", since = "4.15")
     private Long storagePolicy;
 
-    @Parameter(name = ApiConstants.DynamicScalingEnabled,
+    @Parameter(name = ApiConstants.DYNAMIC_SCALING_ENABLED,
             type = CommandType.BOOLEAN,
             description = "true if virtual machine needs to be dynamically scalable of cpu or memory")
     protected Boolean isDynamicScalingEnabled;

api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java

@@ -235,7 +235,7 @@ public class DeployVMCmd extends BaseAsyncCreateCustomIdCmd implements SecurityG
     @LogLevel(LogLevel.Log4jLevel.Off)
     private Map vAppNetworks;
 
-    @Parameter(name = ApiConstants.DynamicScalingEnabled,
+    @Parameter(name = ApiConstants.DYNAMIC_SCALING_ENABLED,
             type = CommandType.BOOLEAN,
             description = "true if virtual machine needs to be dynamically scalable")
     protected Boolean isDynamicScalingEnabled;

api/src/main/java/org/apache/cloudstack/api/response/ServiceOfferingResponse.java

@@ -204,9 +204,9 @@ public class ServiceOfferingResponse extends BaseResponse {
     @Param(description = "Root disk size in GB", since = "4.15")
     private Long rootDiskSize;
 
-    @SerializedName("dynamicscalingenabled")
+    @SerializedName(ApiConstants.DYNAMIC_SCALING_ENABLED)
     @Param(description = "true if virtual machine needs to be dynamically scalable of cpu or memory")
-    private Boolean dynamicscalingenabled;
+    private Boolean dynamicScalingEnabled;
 
     public ServiceOfferingResponse() {
     }
@@ -479,11 +479,11 @@ public void setRootDiskSize(Long rootDiskSize) {
         this.rootDiskSize = rootDiskSize;
     }
 
-    public Boolean getDynamicscalingenabled() {
-        return dynamicscalingenabled;
+    public Boolean getDynamicScalingEnabled() {
+        return dynamicScalingEnabled;
     }
 
-    public void setDynamicscalingenabled(Boolean dynamicscalingenabled) {
-        this.dynamicscalingenabled = dynamicscalingenabled;
+    public void setDynamicScalingEnabled(Boolean dynamicScalingEnabled) {
+        this.dynamicScalingEnabled = dynamicScalingEnabled;
     }
 }

server/src/main/java/com/cloud/api/query/dao/ServiceOfferingJoinDaoImpl.java

@@ -113,7 +113,7 @@ public ServiceOfferingResponse newServiceOfferingResponse(ServiceOfferingJoinVO
         offeringResponse.setObjectName("serviceoffering");
         offeringResponse.setIscutomized(offering.isDynamic());
         offeringResponse.setCacheMode(offering.getCacheMode());
-        offeringResponse.setDynamicscalingenabled(offering.isDynamicallyScalable());
+        offeringResponse.setDynamicScalingEnabled(offering.isDynamicallyScalable());
 
         if (offeringDetails != null && !offeringDetails.isEmpty()) {
             String vsphereStoragePolicyId = offeringDetails.get(ApiConstants.STORAGE_POLICY);