Commit 632f1e4
* [runners-spark] Spark 4 follow-up: address remaining review comments from #38255
Addresses two trailing review comments left on PR #38255 at the
approved/merged head SHA that were never folded in before merge:
- Restore the `feature Y added to Java SDK` placeholder line in
CHANGES.md Highlights (lost to a rebase). Comment:
#38255 (comment)
- Delete two orphaned `.github/trigger_files/*.json`:
- `beam_PreCommit_Java_Spark4_Versions.json`: its workflow YAML was
deleted in #38255.
- `beam_PostCommit_Java_ValidatesRunner_Spark4StructuredStreaming.json`:
flagged as "not effective yet"; since then, #38478 renamed the
associated workflow YAML to
`beam_PostCommit_Java_ValidatesRunner_Spark4.yml`, so this trigger
JSON is doubly orphaned.
Comment:
#38255 (comment)
The renamed workflow YAML stays in place; per the trigger-files
convention these JSONs are only added when an author wants to manually
trigger a specific PostCommit.
* Update CHANGES.md
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
* Fix CHANGES.md URL: /pull/N -> /issues/N for validateChanges
* Update CHANGES.md
Co-authored-by: Yi Hu <huuyyi@gmail.com>
---------
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Yi Hu <huuyyi@gmail.com>
1 parent 13d36eb commit 632f1e4
3 files changed
Lines changed: 2 additions & 6 deletions
File tree
- .github/trigger_files
Lines changed: 0 additions & 3 deletions
This file was deleted.
Lines changed: 0 additions & 3 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| 63 | + | |
| 64 | + | |
63 | 65 | | |
64 | 66 | | |
65 | 67 | | |
| |||
0 commit comments