AXIS2-5904 Fix version capture ordering and remove dead Date fields

Gemini review found a subtle race: getMaxPolicyVersion() was called
AFTER calculateEffectivePolicy(), so a concurrent policy update
between the two calls would stamp the cache with a newer version
than the policy it contains, causing subsequent calls to miss the
update. Fix: capture version BEFORE computing the policy.

Also remove dead lastPolicyCalculatedTime fields and unused Date
imports from both AxisBindingMessage and AxisMessage — all cache
invalidation now uses the version counter exclusively.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: robertlazarski

modules/kernel/src/org/apache/axis2/description/AxisBindingMessage.java

@@ -33,7 +33,6 @@
 
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Date;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -52,7 +51,6 @@ public class AxisBindingMessage extends AxisDescription {
     private boolean fault = false;
 
     private volatile Policy effectivePolicy = null;
-    private volatile Date lastPolicyCalculatedTime = null;
     private volatile long lastPolicyCalculatedVersion = -1;
 
     public boolean isFault() {
@@ -221,9 +219,9 @@ public Policy getEffectivePolicy() {
         if (isPolicyUpdated()) {
             synchronized (this) {
                 if (isPolicyUpdated()) {
+                    final long newVersion = getMaxPolicyVersion();
                     effectivePolicy = calculateEffectivePolicy();
-                    lastPolicyCalculatedTime = new Date();
-                    lastPolicyCalculatedVersion = getMaxPolicyVersion();
+                    lastPolicyCalculatedVersion = newVersion;
                 }
             }
         }

modules/kernel/src/org/apache/axis2/description/AxisMessage.java

@@ -37,7 +37,6 @@
 import javax.xml.namespace.QName;
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Date;
 import java.util.List;
 
 
@@ -67,7 +66,6 @@ public class AxisMessage extends AxisDescription {
     private boolean wrapped = true;
 
     private volatile Policy effectivePolicy = null;
-    private volatile Date lastPolicyCalculatedTime = null;
     private volatile long lastPolicyCalculatedVersion = -1;
 
     public String getMessagePartName() {
@@ -241,9 +239,9 @@ public Policy getEffectivePolicy() {
         if (isPolicyUpdated()) {
             synchronized (this) {
                 if (isPolicyUpdated()) {
+                    final long newVersion = getMaxPolicyVersion();
                     effectivePolicy = calculateEffectivePolicy();
-                    lastPolicyCalculatedTime = new Date();
-                    lastPolicyCalculatedVersion = getMaxPolicyVersion();
+                    lastPolicyCalculatedVersion = newVersion;
                 }
             }
         }