[CI][Release] macOS conda source verification jobs fail to build Arrow C++

[raulcd]

Describe the bug, including details regarding any error messages, version, and platform.

The conda verification jobs on macOS are currently failing:

• verify-rc-source-cpp-macos-conda-amd64
• verify-rc-source-integration-macos-conda-amd64
• verify-rc-source-python-macos-conda-amd64

The error:

 [  9%] Building CXX object src/arrow/CMakeFiles/arrow_array.dir/array/validate.cc.o
In file included from /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/array/diff.cc:21:
In file included from /private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/chrono:1121:
In file included from /private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/charconv:85:
/private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/__charconv/from_chars_floating_point.h:57:1: error: expected ')'
   57 | _LIBCPP_AVAILABILITY_FROM_CHARS_FLOATING_POINT _LIBCPP_HIDE_FROM_ABI inline from_chars_result
      | ^
/private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/__configuration/availability.h:346:56: note: expanded from macro '_LIBCPP_AVAILABILITY_FROM_CHARS_FLOATING_POINT'
  346 | #define _LIBCPP_AVAILABILITY_FROM_CHARS_FLOATING_POINT _LIBCPP_INTRODUCED_IN_LLVM_20_ATTRIBUTE
      |                                                        ^
/private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/__configuration/availability.h:131:92: note: expanded from macro '_LIBCPP_INTRODUCED_IN_LLVM_20_ATTRIBUTE'
  131 | #  define _LIBCPP_INTRODUCED_IN_LLVM_20_ATTRIBUTE __attribute__((macos, strict, introduced = 99.0, message="see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk"))
      |                                                                                            ^
In file included from /Users/runner/work/crossbow/crossbow/arrow/cpp/src/arrow/array/diff.cc:21:
In file included from /private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/chrono:1121:
In file included from /private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/charconv:85:
/private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/__charconv/from_chars_floating_point.h:62:1: error: expected ')'
   62 | _LIBCPP_AVAILABILITY_FROM_CHARS_FLOATING_POINT _LIBCPP_HIDE_FROM_ABI inline from_chars_result
      | ^
/private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/__configuration/availability.h:346:56: note: expanded from macro '_LIBCPP_AVAILABILITY_FROM_CHARS_FLOATING_POINT'
  346 | #define _LIBCPP_AVAILABILITY_FROM_CHARS_FLOATING_POINT _LIBCPP_INTRODUCED_IN_LLVM_20_ATTRIBUTE
      |                                                        ^
/private/var/folders/dw/ystz5y093yx3lnxm0n2_lrgr0000gn/T/arrow-HEAD.XXXXX.48gTlSPayM/miniforge/envs/conda-source/bin/../include/c++/v1/__configuration/availability.h:131:92: note: expanded from macro '_LIBCPP_INTRODUCED_IN_LLVM_20_ATTRIBUTE'
  131 | #  define _LIBCPP_INTRODUCED_IN_LLVM_20_ATTRIBUTE __attribute__((macos, strict, introduced = 99.0, message="see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk"))
      |                                                                                            ^
2 errors generated.
make[2]: *** [src/arrow/CMakeFiles/arrow_array.dir/build.make:331: src/arrow/CMakeFiles/arrow_array.dir/array/diff.cc.o] Error 1

This is happening both on main and the maintenance branch for 23.0.1. We probably have to cherry-pick the fix for the 23.0.1 release if we decide is a blocker.

Component(s)

Continuous Integration, Release

[raulcd]

@h-vetinari @kou this seem to have been failing for the last ~3 weeks on our nightlies. I don't think it's related to any Arrow change. Any idea about the issue? I am trying to understand whether this should be a blocker for 23.0.1 or not.

[h-vetinari]

Not sure how it worked before; perhaps no code used the affected libc++ facilities before; in any case, the fix should be simply as described in the docs mentioned in the error logs:

CXXFLAGS="${CXXFLAGS} -D_LIBCPP_DISABLE_AVAILABILITY"

[pitrou]

Hmm, this looks more like a syntax error than a controlled error as shown in the conda-forge docs. It doesn't hurt to try the suggested fix, though.

[pitrou]

It seems the attribute should be:

__attribute__((availability(macos, strict, introduced = 99.0, message="see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk")))

but according to the error message it is actually:

__attribute__((macos, strict, introduced = 99.0, message="see https://conda-forge.org/docs/maintainer/knowledge_base.html#newer-c-features-with-old-sdk"))

(note: missing "availability" and parentheses)

[h-vetinari]

It seems the attribute should be:

Thanks for pointing that out. It's a bug in https://github.com/conda-forge/libcxx-feedstock/blob/main/recipe/patches/0002-custom-error-message-for-old-sdk.patch