[C++] C++20: use starts_with/ends_with methods

[pitrou]

Describe the enhancement requested

std::string and std::string_view have gained starts_with and ends_with methods that can allow some code simplification (and we can also remove our StartsWith / EndsWith helper functions).

Component(s)

C++

[Jonahkel]

Hi, I'd like to implement this enhancement as my first OSS contribution. Is there anything I should know before I begin?

[Jonahkel]

take

[pitrou]

Yes, of course, feel free to submit a PR @Jonahkel

[Jonahkel]

Are all of the files that need to be changed in cpp/ ?
Also, is it sufficient for me to run the cpp unit tests and style checks after I make my changes?

[Jonahkel]

I made the changes but I'm having trouble testing them. When building using the cmake ninja-debug-basic preset I expect unit test files to be generated in build/debug. However, no tests are generated, so ctest is failing.

[pitrou]

Are all of the files that need to be changed in cpp/ ?

I think so, but you can check by searching through the codebase.

Also, is it sufficient for me to run the cpp unit tests and style checks after I make my changes?

It should. More builds will be run once you open a PR.

[pitrou]

When building using the cmake ninja-debug-basic preset I expect unit test files to be generated in build/debug. However, no tests are generated, so ctest is failing.

ctest should work, but you have to run it from the build directory (or you can pass the directory through a ctest option, I don't remember which one).

[Soumyadeep-4704]

I want to work on this and kickstart my journey in the open-source world. Can I work on this?

[Jonahkel]

I've already made the necessary changes. There's just one failing test I need to address and then it will be done.