Fixed vulnerbility

Author: anujdevopslearn

src/main/java/de/martinspielmann/wicket/pwnedpasswordsvalidator/PwnedPasswordsValidator.java

@@ -2,9 +2,8 @@
 
 import java.io.IOException;
 import java.net.HttpURLConnection;
-import java.net.MalformedURLException;
 import java.net.Proxy;
-import java.net.URL;
+import java.net.URI;
 import java.nio.charset.StandardCharsets;
 import java.security.MessageDigest;
 import java.security.NoSuchAlgorithmException;
@@ -163,7 +162,7 @@ protected Status getResponseStatus(String pw) {
             }
             // if there were results, check if your pw hash was pwned
             String result = IOUtils.toString(c.getInputStream(), StandardCharsets.UTF_8);
-            String lines[] = result.split("\\r?\\n");
+            String[] lines = result.split("\\r?\\n");
             String hashSuffix = getHashSuffix(pw);
             for(String line : lines) {
             	if(line.split(":")[0].equals(hashSuffix)) {
@@ -197,8 +196,8 @@ protected String getHashSuffix(String pw) throws NoSuchAlgorithmException {
 		return sha1(pw).substring(5);
 	}
 
-	protected URL getApiUrl(String pw) throws MalformedURLException, NoSuchAlgorithmException {
-		return new URL(String.format(API_URL, getHashPrefix(pw)));
+	protected URI getApiUrl(String pw) throws NoSuchAlgorithmException {
+		return URI.create(String.format(API_URL, getHashPrefix(pw)));
 	}
 
 	/**

src/test/java/de/martinspielmann/wicket/pwnedpasswordsvalidator/HomePage.java

@@ -1,12 +1,12 @@
 package de.martinspielmann.wicket.pwnedpasswordsvalidator;
 
+import org.apache.wicket.markup.html.WebPage;
+import org.apache.wicket.markup.html.basic.Label;
 import org.apache.wicket.markup.html.form.Form;
 import org.apache.wicket.markup.html.form.PasswordTextField;
 import org.apache.wicket.markup.html.panel.FeedbackPanel;
 import org.apache.wicket.model.Model;
 import org.apache.wicket.request.mapper.parameter.PageParameters;
-import org.apache.wicket.markup.html.basic.Label;
-import org.apache.wicket.markup.html.WebPage;
 
 public class HomePage extends WebPage {
 	private static final long serialVersionUID = 1L;
@@ -16,8 +16,6 @@ public HomePage(final PageParameters parameters) {
 
 		add(new Label("version", getApplication().getFrameworkSettings().getVersion()));
 
-		// TODO Add your page's components here
-
 		Form f = new Form("form");
 		add(f);
 		f.add(new FeedbackPanel("feedback"));

src/test/java/de/martinspielmann/wicket/pwnedpasswordsvalidator/PwnedPasswordsValidatorTest.java

@@ -1,10 +1,9 @@
 package de.martinspielmann.wicket.pwnedpasswordsvalidator;
 
 import java.net.InetSocketAddress;
-import java.net.MalformedURLException;
 import java.net.Proxy;
 import java.net.SocketAddress;
-import java.net.URL;
+import java.net.URI;
 import java.security.NoSuchAlgorithmException;
 import java.util.UUID;
 import java.util.concurrent.atomic.AtomicInteger;
@@ -191,9 +190,9 @@ public void getRateLimitExceededBehavior() {
     }
 
     @Test
-    public void getApiUrl() throws MalformedURLException, NoSuchAlgorithmException {
+    public void getApiUrl() throws NoSuchAlgorithmException {
         PwnedPasswordsValidator v = new PwnedPasswordsValidator();
-        URL u = new URL("https://api.pwnedpasswords.com/range/34873");
+        URI u = URI.create("https://api.pwnedpasswords.com/range/34873");
         Assert.assertEquals(u, v.getApiUrl("secret123"));
     }