fixup! test: migrate app-shell-with-service-worker E2E test to Puppeteer

Author: alan-agius4

packages/angular/build/src/builders/application/execute-post-bundle.ts

@@ -138,13 +138,14 @@ export async function executePostBundleSteps(
 
   // Pre-render (SSG) and App-shell
   // If localization is enabled, prerendering is handled in the inlining process.
+  let indexHtmlOutputPath = indexHtmlOptions?.output;
   if (
     !partialSSRBuild &&
     (prerenderOptions || appShellOptions || (outputMode && serverEntryPoint)) &&
     !allErrors.length
   ) {
     assert(
-      indexHtmlOptions,
+      indexHtmlOptions && indexHtmlOutputPath,
       'The "index" option is required when using the "ssg" or "appShell" options.',
     );
 
@@ -163,17 +164,19 @@ export async function executePostBundleSteps(
     allErrors.push(...errors);
     allWarnings.push(...warnings);
 
-    const indexHasBeenPrerendered = output[indexHtmlOptions.output];
+    const indexHasBeenPrerendered = output[indexHtmlOutputPath];
     for (const [path, { content, appShellRoute }] of Object.entries(output)) {
       // Update the index contents with the app shell under these conditions:
       // - Replace 'index.html' with the app shell only if it hasn't been prerendered yet.
       // - Always replace 'index.csr.html' with the app shell.
       let filePath = path;
       if (appShellRoute && !indexHasBeenPrerendered) {
-        if (outputMode !== OutputMode.Server && indexHtmlOptions.output === INDEX_HTML_CSR) {
+        if (outputMode !== OutputMode.Server && indexHtmlOutputPath === INDEX_HTML_CSR) {
           filePath = 'index.html';
+          // Needed to update the ngsw.json "index" value.
+          indexHtmlOutputPath = filePath;
         } else {
-          filePath = indexHtmlOptions.output;
+          filePath = indexHtmlOutputPath;
         }
       }
 
@@ -232,7 +235,7 @@ export async function executePostBundleSteps(
         workspaceRoot,
         serviceWorker,
         baseHref,
-        options.indexHtmlOptions?.output,
+        indexHtmlOutputPath,
         // Ensure additional files recently added are used
         [...outputFiles, ...additionalOutputFiles],
         assetFiles,

packages/angular/build/src/builders/dev-server/vite/index.ts

@@ -9,19 +9,21 @@
 import type { BuilderContext } from '@angular-devkit/architect';
 import type { Plugin } from 'esbuild';
 import assert from 'node:assert';
-import { builtinModules, isBuiltin } from 'node:module';
 import { join } from 'node:path';
 import type { Connect, ViteDevServer } from 'vite';
 import type { ComponentStyleRecord } from '../../../tools/vite/middlewares';
 import { ServerSsrMode } from '../../../tools/vite/plugins';
 import { EsbuildLoaderOption, updateExternalMetadata } from '../../../tools/vite/utils';
 import { normalizeSourceMaps } from '../../../utils';
-import { useComponentStyleHmr, useComponentTemplateHmr } from '../../../utils/environment-options';
+import {
+  useComponentStyleHmr,
+  useComponentTemplateHmr,
+  usePartialSsrBuild,
+} from '../../../utils/environment-options';
 import { Result, ResultKind } from '../../application/results';
 import { OutputHashing } from '../../application/schema';
 import {
   type ApplicationBuilderInternalOptions,
-  type ExternalResultMetadata,
   JavaScriptTransformer,
   getSupportedBrowsers,
   isZonelessApp,
@@ -119,7 +121,7 @@ export async function* serveWithVite(
 
   // Disable generating a full manifest with routes.
   // This is done during runtime when using the dev-server.
-  browserOptions.partialSSRBuild = true;
+  browserOptions.partialSSRBuild = usePartialSsrBuild;
 
   // The development server currently only supports a single locale when localizing.
   // This matches the behavior of the Webpack-based development server but could be expanded in the future.

packages/angular/build/src/builders/dev-server/vite/utils.ts

@@ -48,42 +48,35 @@ export function updateResultRecord(
     return;
   }
 
-  let filePath;
-  if (outputPath === htmlIndexPath) {
-    // Convert custom index output path to standard index path for dev-server usage.
-    // This mimics the Webpack dev-server behavior.
-    filePath = '/index.html';
-  } else {
-    filePath = '/' + normalizePath(outputPath);
-  }
-
-  const servable =
-    file.type === BuildOutputFileType.Browser || file.type === BuildOutputFileType.Media;
+  const filePath = '/' + normalizePath(outputPath);
+  const generatedFile: OutputFileRecord = {
+    contents: file.contents,
+    size: file.contents.byteLength,
+    hash: file.hash,
+    // Consider the files updated except on the initial build result
+    updated: !initial,
+    type: file.type,
+    servable: file.type === BuildOutputFileType.Browser || file.type === BuildOutputFileType.Media,
+  };
 
   // Skip analysis of sourcemaps
   if (filePath.endsWith('.map')) {
     generatedFiles.set(filePath, {
-      contents: file.contents,
-      servable,
-      size: file.contents.byteLength,
-      hash: file.hash,
-      type: file.type,
+      ...generatedFile,
       updated: false,
     });
 
     return;
   }
 
   // New or updated file
-  generatedFiles.set(filePath, {
-    contents: file.contents,
-    size: file.contents.byteLength,
-    hash: file.hash,
-    // Consider the files updated except on the initial build result
-    updated: !initial,
-    type: file.type,
-    servable,
-  });
+  generatedFiles.set(filePath, generatedFile);
+
+  if (outputPath === htmlIndexPath) {
+    // Convert custom index output path to standard index path for dev-server usage.
+    // This mimics the Webpack dev-server behavior.
+    generatedFiles.set('/index.html', generatedFile);
+  }
 
   // Record any external component styles
   if (filePath.endsWith('.css') && /^\/[a-f0-9]{64}\.css$/.test(filePath)) {

packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts

@@ -12,6 +12,7 @@ import { readFileSync } from 'node:fs';
 import type { ServerResponse } from 'node:http';
 import { extname } from 'node:path';
 import type { Connect, ViteDevServer } from 'vite';
+import { INDEX_HTML_CSR } from '../../../builders/application/options';
 import { ResultFile } from '../../../builders/application/results';
 import { AngularMemoryOutputFiles, AngularOutputAssets, pathnameWithoutBasePath } from '../utils';
 
@@ -96,7 +97,9 @@ export function createAngularAssetsMiddleware(
     // Resource files are handled directly.
     // Global stylesheets (CSS files) are currently considered resources to workaround
     // dev server sourcemap issues with stylesheets.
-    if (extension !== '.js' && extension !== '.html') {
+    // Vite will added the client code even when no-live-reload and no-hmr are passed thus we need to
+    // exclude .js and .html files when hmr is disabled.
+    if ((extension !== '.js' && extension !== '.html') || !server.config.server?.hmr) {
       const outputFile = outputFiles.get(pathname);
       if (outputFile?.servable) {
         let data: Uint8Array | string = outputFile.contents;

tests/e2e/utils/puppeteer.ts

@@ -29,11 +29,14 @@ export async function executeBrowserTest(options: BrowserTestOptions = {}) {
       const { stdout } = await execAndWaitForOutputToMatch('ng', serveArgs, match, {
         ...process.env,
         'NO_COLOR': '1',
+        'NG_BUILD_PARTIAL_SSR': '0',
       });
+
       url = stripVTControlCharacters(stdout).match(match)?.[1];
       if (!url) {
         throw new Error('Could not find serving URL');
       }
+
       hasStartedServer = true;
     }