refactor(@angular/cli): correctly handle yarn classic tag manifest fetching

Introduces a `requiresManifestTagLookup` property to `PackageManagerDescriptor` to control whether a package manager needs an explicit metadata lookup for tags
(or when no `fetchSpec` is provided) before attempting to fetch the full registry manifest.

This change optimizes manifest fetching by enabling a preliminary metadata lookup for package managers like `yarn-classic` that require it to resolve tags to
concrete versions.

Author: clydin

packages/angular/cli/src/package-managers/package-manager-descriptor.ts

@@ -20,7 +20,7 @@ import {
   parseNpmLikeManifest,
   parseNpmLikeMetadata,
   parseYarnClassicDependencies,
-  parseYarnLegacyManifest,
+  parseYarnClassicManifest,
   parseYarnModernDependencies,
 } from './parsers';
 
@@ -73,6 +73,9 @@ export interface PackageManagerDescriptor {
   /** The command to fetch the registry manifest of a package. */
   readonly getManifestCommand: readonly string[];
 
+  /** Whether a tag needs a lookup prior to fetching a registry manifest. */
+  readonly requiresManifestTagLookup?: boolean;
+
   /** A function that formats the arguments for field-filtered registry views. */
   readonly viewCommandFieldArgFormatter?: (fields: readonly string[]) => string[];
 
@@ -166,9 +169,10 @@ export const SUPPORTED_PACKAGE_MANAGERS = {
     versionCommand: ['--version'],
     listDependenciesCommand: ['list', '--depth=0', '--json'],
     getManifestCommand: ['info', '--json'],
+    requiresManifestTagLookup: true,
     outputParsers: {
       listDependencies: parseYarnClassicDependencies,
-      getRegistryManifest: parseYarnLegacyManifest,
+      getRegistryManifest: parseYarnClassicManifest,
       getRegistryMetadata: parseNpmLikeMetadata,
     },
   },

packages/angular/cli/src/package-managers/package-manager.ts

@@ -156,12 +156,14 @@ export class PackageManager {
       return { stdout: '', stderr: '' };
     }
 
-    return this.host.runCommand(this.descriptor.binary, finalArgs, {
+    const commandResult = await this.host.runCommand(this.descriptor.binary, finalArgs, {
       ...runOptions,
       cwd: executionDirectory,
       stdio: 'pipe',
       env: finalEnv,
     });
+
+    return { stdout: commandResult.stdout.trim(), stderr: commandResult.stderr.trim() };
   }
 
   /**
@@ -395,13 +397,26 @@ export class PackageManager {
     switch (type) {
       case 'range':
       case 'version':
-      case 'tag':
+      case 'tag': {
         if (!name) {
           throw new Error(`Could not parse package name from specifier: ${specifier}`);
         }
 
         // `fetchSpec` is the version, range, or tag.
-        return this.getRegistryManifest(name, fetchSpec ?? 'latest', options);
+        let versionSpec = fetchSpec ?? 'latest';
+        if ((type === 'tag' || !fetchSpec) && this.descriptor.requiresManifestTagLookup) {
+          const metadata = await this.getRegistryMetadata(name, options);
+          if (!metadata) {
+            return null;
+          }
+          versionSpec = metadata['dist-tags'][versionSpec];
+          if (!versionSpec) {
+            return null;
+          }
+        }
+
+        return this.getRegistryManifest(name, versionSpec, options);
+      }
       case 'directory': {
         if (!fetchSpec) {
           throw new Error(`Could not parse directory path from specifier: ${specifier}`);

packages/angular/cli/src/package-managers/parsers.ts

@@ -274,7 +274,7 @@ export function parseNpmLikeMetadata(stdout: string, logger?: Logger): PackageMe
  * @param logger An optional logger instance.
  * @returns The package manifest object.
  */
-export function parseYarnLegacyManifest(stdout: string, logger?: Logger): PackageManifest | null {
+export function parseYarnClassicManifest(stdout: string, logger?: Logger): PackageManifest | null {
   logger?.debug(`Parsing yarn classic manifest...`);
   logStdout(stdout, logger);
 
@@ -287,5 +287,7 @@ export function parseYarnLegacyManifest(stdout: string, logger?: Logger): Packag
   const data = JSON.parse(stdout);
 
   // Yarn classic wraps the manifest in a `data` property.
-  return data.data ?? data;
+  const manifest = data.data as PackageManifest;
+
+  return manifest;
 }