Skip to content

Commit a1249d1

Browse files
clydinalan-agius4
authored andcommitted
ci: update Windows CI jobs to use Node.js 24 for test execution
1 parent 0b49827 commit a1249d1

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

.github/workflows/ci.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,8 @@ jobs:
113113
run: |
114114
pnpm bazel build \
115115
--config=e2e \
116-
//tests:e2e.webpack_node22 \
117-
//tests:e2e.esbuild_node22 \
116+
//tests:e2e.webpack_node24 \
117+
//tests:e2e.esbuild_node24 \
118118
--platforms=tools:windows_x64
119119
- name: Store built Windows E2E tests
120120
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
@@ -131,7 +131,7 @@ jobs:
131131
strategy:
132132
fail-fast: false
133133
matrix:
134-
node: [22]
134+
node: [24]
135135
subset: [esbuild, webpack]
136136
shard: [0, 1, 2, 3, 4, 5]
137137
runs-on: windows-2025

.github/workflows/pr.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ jobs:
139139
run: |
140140
pnpm bazel build \
141141
--config=e2e \
142-
//tests:e2e.esbuild_node22 \
142+
//tests:e2e.esbuild_node24 \
143143
--platforms=tools:windows_x64
144144
- name: Store built Windows E2E tests
145145
uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
@@ -167,7 +167,7 @@ jobs:
167167
- name: Run CLI E2E tests
168168
uses: ./.github/shared-actions/windows-bazel-test
169169
with:
170-
test_target_name: e2e.esbuild_node22
170+
test_target_name: e2e.esbuild_node24
171171
env:
172172
E2E_SHARD_TOTAL: 1
173173
TESTBRIDGE_TEST_ONLY: tests/basic/{build,rebuild,serve}.ts

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -180,5 +180,5 @@ register_toolchains(
180180
"@devinfra//bazel/git-toolchain:git_macos_arm64_toolchain",
181181
"@devinfra//bazel/git-toolchain:git_windows_toolchain",
182182
"//tools/toolchains:dummy_cc_windows_no_exec_toolchain",
183-
"//tools/toolchains:node22_windows_no_exec_toolchain",
183+
"//tools/toolchains:node24_windows_no_exec_toolchain",
184184
)

tools/toolchains/BUILD.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ load(":dummy_cc_toolchain.bzl", "dummy_cc_toolchain_config")
33

44
# This is needed following https://github.com/bazel-contrib/rules_nodejs/pull/3859
55
toolchain(
6-
name = "node22_windows_no_exec_toolchain",
6+
name = "node24_windows_no_exec_toolchain",
77
exec_compatible_with = [],
88
target_compatible_with = [
99
"@platforms//os:windows",
1010
"@platforms//cpu:x86_64",
1111
],
12-
toolchain = "@node22_windows_amd64//:toolchain",
12+
toolchain = "@node24_windows_amd64//:toolchain",
1313
toolchain_type = "@rules_nodejs//nodejs:toolchain_type",
1414
)
1515

0 commit comments

Comments
 (0)