refactor(@angular/build): address review feedback for top-level await error

- Use `??=` and `.push()` instead of spread for notes
- Merge two separate notes into a single note with newline
- Use `expect(result?.success).toBeTrue()` and `not.toContain` in test

Author: maruthang

packages/angular/build/src/builders/application/execute-build.ts

@@ -167,19 +167,14 @@ export async function executeBuild(
     if (!isZonelessApp(options.polyfills)) {
       for (const error of bundlingResult.errors) {
         if (error.text?.startsWith(TOP_LEVEL_AWAIT_ERROR_TEXT)) {
-          error.notes = [
-            {
-              text:
-                'Top-level await is not supported in applications that use Zone.js. ' +
-                'Consider removing Zone.js or moving this code into an async function.',
-              location: null,
-            },
-            {
-              text: 'For more information about zoneless Angular applications, visit: https://angular.dev/guide/zoneless',
-              location: null,
-            },
-            ...(error.notes ?? []),
-          ];
+          error.notes ??= [];
+          error.notes.push({
+            text:
+              'Top-level await is not supported in applications that use Zone.js. ' +
+              'Consider removing Zone.js or moving this code into an async function. \n' +
+              'For more information about zoneless Angular applications, visit: https://angular.dev/guide/zoneless',
+            location: null,
+          });
         }
       }
     }

packages/angular/build/src/builders/application/tests/behavior/top-level-await-error_spec.ts

@@ -51,14 +51,15 @@ describeBuilder(buildApplication, APPLICATION_BUILDER_INFO, (harness) => {
       });
 
       const { result, logs } = await harness.executeOnce({ outputLogsOnFailure: false });
-      // Without Zone.js, the build may still fail due to target environment constraints,
-      // but the error should NOT contain the Zone.js-specific message
-      const zoneJsErrorPresent = logs.some(
-        (log) =>
-          typeof log.message === 'string' &&
-          log.message.includes('Top-level await is not supported in applications that use Zone.js'),
+      expect(result?.success).toBeTrue();
+      expect(logs).not.toContain(
+        jasmine.objectContaining({
+          level: 'error',
+          message: jasmine.stringContaining(
+            'Top-level await is not supported in applications that use Zone.js',
+          ),
+        }),
       );
-      expect(zoneJsErrorPresent).toBeFalse();
     });
   });
 });