Next release and maintenance

[felmoreno1726]

The Leaky Socket issue is pernicious. Could you please release the 2.0.1 version?

[felmoreno1726]

@andreikop I'm putting in some work to maintain this project.

• Updating Workflow to build package and test the project
• Updating the failing Test
• Automatically package and publish to PyPi

Would you be willing to make me a contributor/maintainer of the project? And willing to support me with the PyPi portion since you have the ownership?

[andreikop]

If you fixed the tests, I'll release new version.

[felmoreno1726]

@andreikop there are bugs that were introduced with IPv6 support.
#61

I would recommend Publishing a release before IPv6 or fixing these new bugs before making the new release. Pytest are failing with IPv6 because of bugs at the moment.

[wpyoga]

Re. failing tests. There seems to be a few issues that caused the failing tests:

• Default value of fail-fast option in GH actions -- this has been fixed
• Wrong scope id format on Linux, when enumerating IPv6 addresses -- this has been fixed
• The ipaddress library in Python 3.8 and older don't support scope id for IPv6

So now we are left with the last issue. If I may, there seems to be a few ways to handle this:

• Drop support for Python 3.8 and older versions -- will this cause any problems with current users?
• Have special support code for Python 3.8 and older -- is this sustainable?
• Find another library to handle the relevant functionality -- is it worth the hassle?
• Ignore the failing tests, users on Python 3.8 and older can still use IPv4 anyway -- will it cause confusion?

Personally, my suggestion is to either drop support for older versions or ignore the failing tests.

[felmoreno1726]

I'd say we just drop support for 3.8. So if a user still want to use 3.8 then older versions will still work, and future versions will start using 3.9+

There shouldn't be any confusion if this is configured in the setup.py and the packaging itself, so the latest version of the package will fail to install in an environment with Python 3.8 or older.

[jterrace]

3.8 reached end of life already, so I'd recommend dropping support for it - https://devguide.python.org/versions/

[wpyoga]

@andreikop Are there still issues/blockers with the tests?

[andreikop]

I've released current master

[jterrace]

Thanks, @andreikop ! Could I ask you to push a tag too?
https://github.com/andreikop/python-ws-discovery/tags

[bdraco]

@andreikop I ran into a few issues when I tried to update Home Assistant to use the new version (mostly around IPv6) in home-assistant/core#136363

Would you mind taking a look at the following PRs?

#82
#85
#88
#87
#83

[andreikop]

Thanks, @andreikop ! Could I ask you to push a tag too? https://github.com/andreikop/python-ws-discovery/tags

done

[bdraco]

@andreikop

I just retested master with Home Assistant and everything is working great now.

Many thanks for getting those fixes merged quickly.

As soon as a new release is available, I will update home-assistant/core#136363 This is a great set of changes as it means Home Assistant will be able to detect many more cameras and save users many hours finding the right ports / IPs.

Thanks!

[andreikop]

@bdraco I've published v2.1.2