Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Exposure/Exposure.php
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ public function toEvents(): array
} elseif ($variant->value) {
$event->eventProperties['[Experiment] Variant'] = $variant->value;
}
$experimentKey = $variant->metadata['experimentKey'] ?? null;
if ($experimentKey) {
$event->eventProperties['[Experiment] Experiment Key'] = $experimentKey;
}
if ($variant->metadata) {
$event->eventProperties['metadata'] = $variant->metadata;
}
Expand Down
26 changes: 20 additions & 6 deletions tests/Exposure/ExposureServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,13 @@ public function testToEventsCreatesOneEventPerFlag()
]);
$emptyMetadata = new Variant('on', 'on');
$emptyVariant = new Variant();
$withExperimentKey = new Variant('treatment', 'treatment', null, null, [
'segmentName' => 'All Other Users',
'flagType' => 'experiment',
'flagVersion' => 10,
'default' => false,
'experimentKey' => 'exp-1'
]);
$results = [
'basic' => $basic,
'different_value' => $differentValue,
Expand All @@ -77,23 +84,24 @@ public function testToEventsCreatesOneEventPerFlag()
'holdout' => $holdout,
'partial_metadata' => $partialMetadata,
'empty_metadata' => $emptyMetadata,
'empty_variant' => $emptyVariant
'empty_variant' => $emptyVariant,
'with_experiment_key' => $withExperimentKey
];
$exposure = new Exposure($user, $results);
$events = $exposure->toEvents();
// Should exclude default (default=true) only
// basic, different_value, mutex, holdout, partial_metadata, empty_metadata, empty_variant = 7 events
$this->assertCount(7, $events);
// basic, different_value, mutex, holdout, partial_metadata, empty_metadata, empty_variant, with_experiment_key = 8 events
$this->assertCount(8, $events);

foreach ($events as $event) {
$this->assertEquals('[Experiment] Exposure', $event->eventType);
$this->assertEquals($user->userId, $event->userId);
$this->assertEquals($user->deviceId, $event->deviceId);

$flagKey = $event->eventProperties['[Experiment] Flag Key'];
$this->assertArrayHasKey($flagKey, $results);
$variant = $results[$flagKey];

// Validate event properties
if ($variant->key) {
$this->assertEquals($variant->key, $event->eventProperties['[Experiment] Variant']);
Expand All @@ -103,6 +111,12 @@ public function testToEventsCreatesOneEventPerFlag()
if ($variant->metadata) {
$this->assertEquals($variant->metadata, $event->eventProperties['metadata']);
}

if ($flagKey === 'with_experiment_key') {
$this->assertEquals('exp-1', $event->eventProperties['[Experiment] Experiment Key']);
} else {
$this->assertArrayNotHasKey('[Experiment] Experiment Key', $event->eventProperties);
}

// Validate user properties
$flagType = $variant->metadata['flagType'] ?? null;
Expand Down
Loading