Problem
The agent's initial fix threw a click.BadParameter error for both CLI and config file exclusions. This meant that configuration file errors were reported as CLI parameter errors, creating a poor user experience. It took an external automated review to point out this UX issue.
Impact
- Suboptimal user experience (confusing error messages)
- Required external intervention to catch the issue
- Agent didn't proactively consider the context difference between CLI and config errors
Context
This issue was identified during the bugfix session for ambient-code/agentready#306 addressing ambient-code/agentready#302.
The agent should have recognized that:
- CLI errors →
click.BadParameter (appropriate)
- Config file errors →
click.ClickException (better UX)
Recommended Solution
The bugfix workflow should:
Could add a "User Experience Review" section that prompts the agent to:
- Test error paths manually
- Verify error messages are clear and actionable
- Ensure errors point users to the right place to fix issues
Reference
From PR comment: #42 (comment)
Problem
The agent's initial fix threw a
click.BadParametererror for both CLI and config file exclusions. This meant that configuration file errors were reported as CLI parameter errors, creating a poor user experience. It took an external automated review to point out this UX issue.Impact
Context
This issue was identified during the bugfix session for ambient-code/agentready#306 addressing ambient-code/agentready#302.
The agent should have recognized that:
click.BadParameter(appropriate)click.ClickException(better UX)Recommended Solution
The bugfix workflow should:
/fixphase about considering error message UXCould add a "User Experience Review" section that prompts the agent to:
Reference
From PR comment: #42 (comment)