Skip to content

Commit 7d33f1a

Browse files
Ambient Code Botclaude
andcommitted
fix(cli,manifests): address CodeRabbit review feedback
- send.go: RUN_ERROR now returns an error (exit non-zero) instead of nil; RUN_FINISHED and RUN_ERROR both flush trailing newline before returning - ambient-api-server.yaml: add resource requests/limits to migration initContainer (cpu: 50m-500m, memory: 128Mi-512Mi) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent eeb17f7 commit 7d33f1a

2 files changed

Lines changed: 16 additions & 1 deletion

File tree

components/ambient-cli/cmd/acpctl/session/send.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,8 +136,16 @@ func runSend(cmd *cobra.Command, args []string) error {
136136
}
137137
fmt.Fprintf(out, "→ %s\n", preview)
138138
}
139-
case "RUN_FINISHED", "RUN_ERROR":
139+
case "RUN_FINISHED":
140+
if inText {
141+
fmt.Fprintln(out)
142+
}
140143
return nil
144+
case "RUN_ERROR":
145+
if inText {
146+
fmt.Fprintln(out)
147+
}
148+
return fmt.Errorf("run failed")
141149
}
142150
}
143151

components/manifests/overlays/mpp-openshift/ambient-api-server.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,13 @@ spec:
6868
volumeMounts:
6969
- name: db-secrets
7070
mountPath: /secrets/db
71+
resources:
72+
requests:
73+
cpu: 50m
74+
memory: 128Mi
75+
limits:
76+
cpu: 500m
77+
memory: 512Mi
7178
securityContext:
7279
allowPrivilegeEscalation: false
7380
readOnlyRootFilesystem: false

0 commit comments

Comments
 (0)