-
Notifications
You must be signed in to change notification settings - Fork 554
feat: add diskann index #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
richyreachy
wants to merge
64
commits into
alibaba:main
Choose a base branch
from
richyreachy:feat/diskann_index
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
e38efb9
feat: add diskann index
richyreachy 43c9db5
fix: add libaio dependency
richyreachy 043456d
Merge branch 'main' into feat/diskann_index
richyreachy dae465c
fix: fix initialization
richyreachy 1202e42
Merge branch 'feat/diskann_index' of github.com:richyreachy/zvec into…
richyreachy d9503d3
Merge branch 'main' into feat/diskann_index
richyreachy c24cd82
refactor: fix ut
richyreachy 87a1b8c
Merge branch 'feat/diskann_index' of github.com:richyreachy/zvec into…
richyreachy 4e668da
fix: fix seed value
richyreachy fe60376
fix: fix seed value
richyreachy dc3d0a8
fix: update ut
richyreachy 071d275
Merge branch 'main' into feat/diskann_index
richyreachy 78eea04
fix: fix ut
richyreachy 41f893d
Merge branch 'main' into feat/diskann_index
richyreachy 4cc1ecb
fix: fix according to pr comments
richyreachy 35192e7
Merge branch 'feat/diskann_index' of github.com:richyreachy/zvec into…
richyreachy 53f9ef9
fix: fix on comments
richyreachy f3ee4ca
fix: fix yaml
richyreachy fd71a06
feat: support dynamic load
richyreachy 17570d7
feat: add dynamic load
richyreachy 9ac2c3f
Merge branch 'main' into feat/diskann_index
richyreachy b9a19d1
fix: plugin
richyreachy 9712bd5
fix: plugin
richyreachy e7bceb4
fix: plugin
richyreachy 9c91f11
fix: fix yaml
richyreachy 1c486f3
fix: plugin
richyreachy 56fcc95
fix: plugin
richyreachy 32954a1
fix: fix plugin
richyreachy c0b2a8f
Revert "fix: fix plugin"
richyreachy 916c870
Merge branch 'main' into feat/diskann_dynamic_load
richyreachy f78ff5d
fix: fix ut
richyreachy 7fec86c
Merge branch 'feat/diskann_index' into feat/diskann_dynamic_load
richyreachy ac1bad7
fix: fix windows build
richyreachy bf6365d
Merge branch 'main' into feat/diskann_dynamic_load
richyreachy a2fa6f2
fix: fix build
richyreachy 9d0a63b
feat: merge with main
richyreachy 7e07c0b
feat: merge with main
richyreachy 1e23806
fix: fix buffer storage
richyreachy 9b0e226
Merge branch 'feat/diskann_index' into feat/diskann_dynamic_load
richyreachy 5d5634a
refactor: use silent invokation
richyreachy 2b561f9
Merge branch 'main' into feat/diskann_dynamic_load
richyreachy 12ae920
Merge branch 'main' into feat/diskann_index
richyreachy 08736db
fix: fix build
richyreachy 58bbc07
Merge branch 'main' into feat/diskann_dynamic_load
richyreachy 0caea47
fix: fix python
richyreachy e8706a8
Merge branch 'feat/diskann_dynamic_load' of github.com:richyreachy/zv…
richyreachy 259d69b
refactor: change macro
richyreachy 5951ecb
Merge branch 'main' into feat/diskann_index
richyreachy 93a6ec9
fix: fix symbol
richyreachy 0beaa3d
fix: fix symbol
richyreachy 2a7bfd1
fix: fix symbol
richyreachy e723a03
feat: add ut
richyreachy c18cdc1
Merge branch 'feat/diskann_dynamic_load' into feat/diskann_index
richyreachy ca60517
Merge branch 'main' into feat/diskann_index
richyreachy 7221594
fix: fix clang tidy
richyreachy ef06317
fix: add lib
richyreachy 55268ef
Merge branch 'main' into feat/diskann_index
richyreachy 76ca655
fix: deprecation warning
richyreachy 689d987
Merge branch 'main' into feat/diskann_index
richyreachy c991124
Merge branch 'main' into feat/diskann_index
richyreachy 1b19ee2
fix: fix win ut
richyreachy 5190f9a
Merge branch 'feat/diskann_index' of github.com:richyreachy/zvec into…
richyreachy 71d6701
Merge branch 'main' into feat/diskann_index
richyreachy 9423d60
Merge branch 'main' into feat/diskann_index
richyreachy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -60,6 +60,14 @@ jobs: | |
| sudo apt-get install -y clang libomp-dev | ||
| shell: bash | ||
|
|
||
| - name: Install AIO | ||
| if: runner.os == 'Linux' && runner.arch == 'X64' | ||
| run: | | ||
| sudo apt-get update | ||
| sudo apt-get install -y --no-install-recommends \ | ||
| libaio-dev | ||
| shell: bash | ||
|
|
||
| - name: Print CPU info | ||
| if: runner.os == 'Linux' | ||
| run: lscpu | ||
|
|
@@ -96,7 +104,7 @@ jobs: | |
| pytest-xdist \ | ||
| scikit-build-core \ | ||
| setuptools_scm | ||
| shell: bash | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 把bash加回去吧,统一一点,并且如果后续这里是多行命令,在非bash为默认shell的环境下可能会出问题
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
| shell: bash | ||
|
|
||
| - name: Build from source | ||
| run: | | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果用户的环境没有装libaio-dev,会发生什么?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在默认使用是需要安装libaio,可以通过配置的方式进行区分,千问的建议是通过linux安装包的方式安装libaio库:
Installation
zvec requires the
libaiosystem library on linux platform.On Ubuntu/Debian:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
如果没有安装,会发生什么?这里预期的行为应该是 如果用户不安装aio,不影响除diskann的其他功能使用
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在新的PR里做了调整:#378