Don't force-enable color if env.CI is set #96
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
@alexeyraspopov, are you able to review this one? It'd help Mocha clean up its dependencies, otherwise we might start a fork of picocolors to work around this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #79.
Re-fixes #41, which #87 purported to fix but did not.
In order to replace chalk everywhere, we should match the behavior of the
supports-colorpackage, which always disables color if stdout is not a TTY. This occurs before any CI checks.This means that GitHub Actions output will once again be uncolored, but this matches how chalk and supports-color behave. It's a bit less pretty, but avoids nasty compatibility issues like I encountered in mochajs/mocha#5471.
Maybe we should change the check to
(p.stdout || {isTTY: true}).isTTY, for further compatibility?