fix(application): error handling if application_versions called with … (#178)

* fix(application): error handling if application_versions called with str arg

* fix(application): error handling if application_versions called with str arg

* fix(application): error handling if application_versions called with str arg

* chore(tests): allow retry of another e2e test, given connection closed by server leading to SSL Errors, see https://github.com/aignostics/python-sdk/actions/runs/18486770436/job/52671622634\?pr\=178\#step:16:274

Author: helmut-hoffer-von-ankershoffen

noxfile.py

@@ -385,10 +385,10 @@ def _generate_readme(session: nox.Session) -> None:
     preamble = "\n[//]: # (README.md generated from docs/partials/README_*.md)\n\n"
     header = Path("docs/partials/README_header.md").read_text(encoding="utf-8")
     main = Path("docs/partials/README_main.md").read_text(encoding="utf-8")
-    platform_section = Path("docs/partials/README_platform.md").read_text(encoding="utf-8")
+    platform = Path("docs/partials/README_platform.md").read_text(encoding="utf-8")
     glossary = Path("docs/partials/README_glossary.md").read_text(encoding="utf-8")
     footer = Path("docs/partials/README_footer.md").read_text(encoding="utf-8")
-    readme_content = f"{preamble}{header}\n\n{main}\n\n{platform_section}\n\n{footer}\n\n{glossary}"
+    readme_content = f"{preamble}{header}\n\n{main}\n\n{platform}\n\n{footer}\n\n{glossary}"
     Path("README.md").write_text(readme_content, encoding="utf-8")
     session.log("Generated README.md file from partials")
 

src/aignostics/application/_service.py

@@ -313,11 +313,11 @@ def application_version(
         message = f"Application version with ID {application_version_id} not found in application {application_id}"
         raise NotFoundException(message)
 
-    def application_versions(self, application: Application) -> list[ApplicationVersion]:
+    def application_versions(self, application: Application | str) -> list[ApplicationVersion]:
         """Get a list of all versions of the given application.
 
         Args:
-            application (Application): The application to check for versions.
+            application (Application | str): The application to check for versions.
 
         Returns:
             list[ApplicationVersion]: A list of all application versions sorted by semantic versioning (latest first).
@@ -328,18 +328,20 @@ def application_versions(self, application: Application) -> list[ApplicationVers
         try:
             return self._get_platform_client().applications.versions.list_sorted(application=application)
         except Exception as e:
-            message = f"Failed to retrieve application versions for application '{application.application_id}': {e}"
+            app_id = application if isinstance(application, str) else application.application_id
+            message = f"Failed to retrieve application versions for application '{app_id}': {e}"
             logger.exception(message)
             raise RuntimeError(message) from e
 
-    def application_version_latest(self, application: Application) -> ApplicationVersion | None:
+    def application_version_latest(self, application: Application | str) -> ApplicationVersion | None:
         """Get a latest application version.
 
         Args:
-            application (Application): The application to check for versions.
+            application (Application | str): The application to check for versions.
 
         Returns:
-            ApplicationVersion | None: A list of all application versions.
+            ApplicationVersion | None: The latest version of the given application,
+                or None if no latest version found.
 
         Raises:
             NotFoundException: If the application with the given ID is not found.

tests/aignostics/application/gui_test.py

@@ -139,6 +139,7 @@ async def test_gui_cli_submit_to_run_result_delete(user: User, runner: CliRunner
 
 @pytest.mark.e2e
 @pytest.mark.long_running
+@pytest.mark.flaky(retries=1, delay=5)
 @pytest.mark.timeout(timeout=60 * 10)
 @pytest.mark.sequential
 async def test_gui_download_dataset_via_application_to_run_cancel(  # noqa: PLR0915

tests/aignostics/application/service_test.py

@@ -8,7 +8,7 @@
 from tests.contants_test import HETA_APPLICATION_ID
 
 
-@pytest.mark.e2e
+@pytest.mark.unit
 def test_application_version_valid_semver_formats(runner: CliRunner) -> None:
     """Test that valid semver formats are accepted."""
     from aignostics.application import Service as ApplicationService
@@ -75,6 +75,7 @@ def test_application_version_invalid_semver_formats(runner: CliRunner) -> None:
 
 
 @pytest.mark.e2e
+@pytest.mark.timeout(timeout=60)
 def test_application_version_use_latest_fallback(runner: CliRunner) -> None:
     """Test that use_latest_if_no_version_given works correctly."""
     service = ApplicationService()
@@ -91,3 +92,77 @@ def test_application_version_use_latest_fallback(runner: CliRunner) -> None:
 
     with pytest.raises(ValueError, match=r"Invalid application version id format"):
         service.application_version("invalid-format", use_latest_if_no_version_given=False)
+
+
+@pytest.mark.e2e
+@pytest.mark.flaky(retries=1, delay=5)
+@pytest.mark.timeout(timeout=60)
+def test_application_versions_with_str_arg(runner: CliRunner, silent_logging: None) -> None:
+    """Test that application_versions works correctly when passed a string application ID."""
+    service = ApplicationService()
+
+    # Test with valid application ID as string
+    versions = service.application_versions(HETA_APPLICATION_ID)
+    assert isinstance(versions, list)
+    # If there are versions, verify they are ApplicationVersion objects
+    if versions:
+        from aignostics.platform import ApplicationVersion
+
+        assert all(isinstance(v, ApplicationVersion) for v in versions)
+
+
+@pytest.mark.e2e
+@pytest.mark.flaky(retries=1, delay=5)
+@pytest.mark.timeout(timeout=60)
+def test_application_version_latest_with_str_arg(runner: CliRunner, silent_logging: None) -> None:
+    """Test that application_version_latest works correctly when passed a string application ID."""
+    service = ApplicationService()
+
+    # Test with valid application ID as string
+    latest = service.application_version_latest(HETA_APPLICATION_ID)
+    # May be None if no versions exist, but should not raise an error
+    if latest is not None:
+        from aignostics.platform import ApplicationVersion
+
+        assert isinstance(latest, ApplicationVersion)
+        assert latest.application_version_id.startswith(f"{HETA_APPLICATION_ID}:v")
+
+
+@pytest.mark.unit
+def test_application_versions_exception_handling_with_str_arg() -> None:
+    """Test that exception handling correctly uses string application ID in error message."""
+    from unittest.mock import MagicMock, patch
+
+    service = ApplicationService()
+
+    # Mock the platform client to raise an exception
+    with patch.object(service, "_get_platform_client") as mock_client:
+        mock_versions = MagicMock()
+        mock_versions.list_sorted.side_effect = Exception("Test error")
+        mock_client.return_value.applications.versions = mock_versions
+
+        # Test with string application ID
+        test_app_id = "test-application-id"
+        expected_error = rf"Failed to retrieve application versions for application '{test_app_id}'"
+        with pytest.raises(RuntimeError, match=expected_error):
+            service.application_versions(test_app_id)
+
+
+@pytest.mark.unit
+def test_application_version_latest_exception_handling_with_str_arg() -> None:
+    """Test exception handling in application_version_latest with string application ID."""
+    from unittest.mock import MagicMock, patch
+
+    service = ApplicationService()
+
+    # Mock the platform client to raise an exception
+    with patch.object(service, "_get_platform_client") as mock_client:
+        mock_versions = MagicMock()
+        mock_versions.list_sorted.side_effect = Exception("Test error")
+        mock_client.return_value.applications.versions = mock_versions
+
+        # Test with string application ID
+        test_app_id = "test-application-id"
+        expected_error = rf"Failed to retrieve application versions for application '{test_app_id}'"
+        with pytest.raises(RuntimeError, match=expected_error):
+            service.application_version_latest(test_app_id)