refactor(tests): move inline imports to top of file

All imports in test functions moved to module-level per project convention.

Author: ari-nz

tests/aignostics/application/cli_test.py

@@ -3,6 +3,7 @@
 import contextlib
 import json
 import platform
+import random
 import re
 from collections.abc import Generator
 from datetime import UTC, datetime, timedelta
@@ -11,6 +12,19 @@
 from unittest.mock import MagicMock, patch
 
 import pytest
+from aignx.codegen.exceptions import ForbiddenException
+from aignx.codegen.exceptions import NotFoundException as ApiNotFound
+from aignx.codegen.models import (
+    ItemOutput,
+    ItemResultReadResponse,
+    ItemState,
+    ItemTerminationReason,
+    RunItemStatistics,
+    RunOutput,
+    RunReadResponse,
+    RunState,
+    RunTerminationReason,
+)
 from loguru import logger
 from tenacity import Retrying, retry, stop_after_attempt, wait_exponential
 from typer.testing import CliRunner
@@ -851,8 +865,6 @@ def test_cli_run_list_for_organization(runner: CliRunner) -> None:
 @pytest.mark.unit
 def test_cli_run_list_forbidden_with_organization(runner: CliRunner) -> None:
     """Check ForbiddenException with --for-organization shows org-specific access denied message."""
-    from aignx.codegen.exceptions import ForbiddenException
-
     with patch.object(
         ApplicationService, "application_runs", side_effect=ForbiddenException(status=403, reason="Forbidden")
     ):
@@ -866,8 +878,6 @@ def test_cli_run_list_forbidden_with_organization(runner: CliRunner) -> None:
 @pytest.mark.unit
 def test_cli_run_list_forbidden_without_organization(runner: CliRunner) -> None:
     """Check ForbiddenException without --for-organization shows generic access denied message."""
-    from aignx.codegen.exceptions import ForbiddenException
-
     with patch.object(
         ApplicationService, "application_runs", side_effect=ForbiddenException(status=403, reason="Forbidden")
     ):
@@ -901,18 +911,6 @@ def test_cli_run_describe_not_found(runner: CliRunner, record_property) -> None:
 @pytest.mark.integration
 def test_cli_run_describe_json_includes_items(runner: CliRunner) -> None:
     """Check run describe --format=json includes items in output."""
-    from aignx.codegen.models import (
-        ItemOutput,
-        ItemResultReadResponse,
-        ItemState,
-        ItemTerminationReason,
-        RunItemStatistics,
-        RunOutput,
-        RunReadResponse,
-        RunState,
-        RunTerminationReason,
-    )
-
     mock_run_data = RunReadResponse(
         run_id="test-run-id-123",
         application_id="test-app",
@@ -1226,9 +1224,6 @@ def test_cli_run_update_item_metadata_not_dict(runner: CliRunner) -> None:
 @pytest.mark.sequential
 def test_cli_run_dump_and_update_custom_metadata(runner: CliRunner, tmp_path: Path) -> None:
     """Test dumping and updating custom metadata via CLI commands."""
-    import json
-    import random
-
     unique_tag = f"test_metadata_{datetime.now(tz=UTC).timestamp()}"
     with submitted_run(runner, tmp_path, CSV_CONTENT_SPOT0, extra_args=["--tags", unique_tag, "--force"]) as run_id:
         # Step 1: Dump initial custom metadata of run
@@ -1317,11 +1312,8 @@ def test_cli_run_dump_and_update_custom_metadata(runner: CliRunner, tmp_path: Pa
 @pytest.mark.e2e
 @pytest.mark.timeout(timeout=240)
 @pytest.mark.sequential
-def test_cli_run_dump_and_update_item_custom_metadata(runner: CliRunner, tmp_path: Path) -> None:  # noqa: PLR0915
+def test_cli_run_dump_and_update_item_custom_metadata(runner: CliRunner, tmp_path: Path) -> None:
     """Test dumping and updating item custom metadata via CLI commands."""
-    import json
-    import random
-
     unique_tag = f"test_item_metadata_{datetime.now(tz=UTC).timestamp()}"
     # CSV_CONTENT_SPOT0 uses SPOT_0_FILENAME as external_id, which the describe output surfaces
     # as "Item External ID: `...`" — the get_external_id() helper below captures it dynamically.
@@ -1777,8 +1769,6 @@ def test_cli_application_version_document_describe_success(runner: CliRunner, re
 def test_cli_application_version_document_describe_not_found(runner: CliRunner, record_property) -> None:
     """`application version document describe` exits 2 with a clear message on 404."""
     record_property("tested-item-id", "TC-APPLICATION-CLI-05-03")
-    from aignx.codegen.exceptions import NotFoundException as ApiNotFound
-
     fake_documents = MagicMock()
     fake_documents.details.side_effect = ApiNotFound(status=404, reason=API_REASON_NOT_FOUND)
     fake_client = MagicMock()
@@ -1874,8 +1864,6 @@ def test_cli_application_version_document_list_json_empty(runner: CliRunner, rec
 def test_cli_application_version_document_list_resolve_not_found_text(runner: CliRunner, record_property) -> None:
     """`application version document list` exits 2 when the application version cannot be resolved."""
     record_property("tested-item-id", "TC-APPLICATION-CLI-05-01")
-    from aignx.codegen.exceptions import NotFoundException as ApiNotFound
-
     fake_client = MagicMock()
     fake_client.applications.versions.documents.side_effect = ApiNotFound(status=404, reason=API_REASON_NOT_FOUND)
 
@@ -1892,8 +1880,6 @@ def test_cli_application_version_document_list_resolve_not_found_text(runner: Cl
 def test_cli_application_version_document_list_resolve_not_found_json(runner: CliRunner, record_property) -> None:
     """`application version document list --format json` emits structured error on 404."""
     record_property("tested-item-id", "TC-APPLICATION-CLI-05-01")
-    from aignx.codegen.exceptions import NotFoundException as ApiNotFound
-
     fake_client = MagicMock()
     fake_client.applications.versions.documents.side_effect = ApiNotFound(status=404, reason=API_REASON_NOT_FOUND)
 
@@ -1980,8 +1966,6 @@ def test_cli_application_version_document_describe_json_success(runner: CliRunne
 def test_cli_application_version_document_describe_resolve_not_found_text(runner: CliRunner, record_property) -> None:
     """`describe` exits 2 when the application version cannot be resolved (text format)."""
     record_property("tested-item-id", "TC-APPLICATION-CLI-05-03")
-    from aignx.codegen.exceptions import NotFoundException as ApiNotFound
-
     fake_client = MagicMock()
     fake_client.applications.versions.documents.side_effect = ApiNotFound(status=404, reason=API_REASON_NOT_FOUND)
 
@@ -2000,8 +1984,6 @@ def test_cli_application_version_document_describe_resolve_not_found_text(runner
 def test_cli_application_version_document_describe_resolve_not_found_json(runner: CliRunner, record_property) -> None:
     """`describe --format json` emits structured error when version cannot be resolved."""
     record_property("tested-item-id", "TC-APPLICATION-CLI-05-03")
-    from aignx.codegen.exceptions import NotFoundException as ApiNotFound
-
     fake_client = MagicMock()
     fake_client.applications.versions.documents.side_effect = ApiNotFound(status=404, reason=API_REASON_NOT_FOUND)
 
@@ -2030,8 +2012,6 @@ def test_cli_application_version_document_describe_resolve_not_found_json(runner
 def test_cli_application_version_document_describe_not_found_json(runner: CliRunner, record_property) -> None:
     """`describe --format json` emits structured error when the document is missing."""
     record_property("tested-item-id", "TC-APPLICATION-CLI-05-03")
-    from aignx.codegen.exceptions import NotFoundException as ApiNotFound
-
     fake_documents = MagicMock()
     fake_documents.details.side_effect = ApiNotFound(status=404, reason=API_REASON_NOT_FOUND)
     fake_client = MagicMock()
@@ -2115,8 +2095,6 @@ def test_cli_application_version_document_download_resolve_not_found(
 ) -> None:
     """`download` exits 2 when the application version cannot be resolved."""
     record_property("tested-item-id", "TC-APPLICATION-CLI-05-04")
-    from aignx.codegen.exceptions import NotFoundException as ApiNotFound
-
     fake_client = MagicMock()
     fake_client.applications.versions.documents.side_effect = ApiNotFound(status=404, reason=API_REASON_NOT_FOUND)
 
@@ -2146,8 +2124,6 @@ def test_cli_application_version_document_download_not_found(
 ) -> None:
     """`download` exits 2 with a clear message when the document does not exist."""
     record_property("tested-item-id", "TC-APPLICATION-CLI-05-04")
-    from aignx.codegen.exceptions import NotFoundException as ApiNotFound
-
     fake_documents = MagicMock()
     fake_documents.download_to_path.side_effect = ApiNotFound(status=404, reason=API_REASON_NOT_FOUND)
     fake_client = MagicMock()

tests/aignostics/platform/e2e_test.py

@@ -6,12 +6,14 @@
 
 """
 
+import itertools
 import os
 import tempfile
 from datetime import UTC, datetime, timedelta
 from pathlib import Path
 
 import pytest
+import requests
 from aignx.codegen.models import (
     ArtifactOutput,
     ArtifactState,
@@ -770,8 +772,6 @@ def _find_available_artifact_in_recent_heta_run() -> tuple[Run, str] | None:
     Returns:
         tuple[Run, str] | None: A bound (Run, output_artifact_id) pair, or None.
     """
-    import itertools
-
     client = platform.Client()
     # client.runs.list yields Run handles directly; iterate lazily and cap to N
     # so the canary stays well under its 60s timeout even on a busy staging env.
@@ -827,10 +827,6 @@ def test_platform_artifact_file_endpoint_resolves_to_working_url(record_property
     """
     record_property("tested-item-id", "SPEC-PLATFORM-SERVICE")
 
-    # Local import: requests is already an SDK dep; importing at use-site avoids
-    # adding to the module-level imports of an otherwise import-heavy test file.
-    import requests
-
     found = _find_available_artifact_in_recent_heta_run()
     if found is None:
         pytest.skip(

tests/aignostics/system/cli_test.py

@@ -1,15 +1,17 @@
 """Tests to verify the CLI functionality of the system module."""
 
+import json
 import logging
 import os
 from pathlib import Path
 from unittest.mock import AsyncMock, MagicMock, patch
 
 import pytest
+import yaml
 from typer.testing import CliRunner
 
 from aignostics.cli import cli
-from aignostics.utils import __project_name__
+from aignostics.utils import Health, __project_name__
 from tests.conftest import normalize_output
 
 THE_VALUE = "test_secret_value_not_real_for_testing_only"
@@ -20,8 +22,6 @@
 def test_cli_health_json_format(mock_service: MagicMock, runner: CliRunner, record_property) -> None:
     """Check health CLI renders UP status correctly as JSON."""
     record_property("tested-item-id", "TEST-SYSTEM-CLI-HEALTH-JSON")
-    from aignostics.utils import Health
-
     mock_service.health = AsyncMock(return_value=Health(status=Health.Code.UP))
     result = runner.invoke(cli, ["system", "health"])
     assert result.exit_code == 0
@@ -33,8 +33,6 @@ def test_cli_health_json_format(mock_service: MagicMock, runner: CliRunner, reco
 def test_cli_health_yaml_format(mock_service: MagicMock, runner: CliRunner, record_property) -> None:
     """Check health CLI renders UP status correctly as YAML."""
     record_property("tested-item-id", "TEST-SYSTEM-CLI-HEALTH-YAML")
-    from aignostics.utils import Health
-
     mock_service.health = AsyncMock(return_value=Health(status=Health.Code.UP))
     result = runner.invoke(cli, ["system", "health", "--output-format", "yaml"])
     assert result.exit_code == 0
@@ -48,8 +46,6 @@ def test_cli_health_yaml_format(mock_service: MagicMock, runner: CliRunner, reco
 @pytest.mark.timeout(timeout=60)
 def test_cli_health_json(runner: CliRunner) -> None:
     """Check health CLI returns valid JSON with a valid status value."""
-    import json
-
     result = runner.invoke(cli, ["system", "health"])
     data = json.loads(result.stdout)
     assert data["status"] in {"UP", "DEGRADED", "DOWN"}
@@ -59,8 +55,6 @@ def test_cli_health_json(runner: CliRunner) -> None:
 @pytest.mark.timeout(timeout=30)
 def test_cli_health_yaml(runner: CliRunner) -> None:
     """Check health CLI returns valid YAML with a valid status value."""
-    import yaml
-
     result = runner.invoke(cli, ["system", "health", "--output-format", "yaml"])
     data = yaml.safe_load(result.stdout)
     assert data["status"] in {"UP", "DEGRADED", "DOWN"}
@@ -118,8 +112,6 @@ def test_cli_info_secrets(runner: CliRunner, caplog: pytest.LogCaptureFixture, r
 @patch("aignostics.system._cli._service")
 def test_cli_health_up_exits_zero(mock_service: MagicMock, runner: CliRunner) -> None:
     """Check health command exits with code 0 when status is UP."""
-    from aignostics.utils import Health
-
     mock_service.health = AsyncMock(return_value=Health(status=Health.Code.UP))
     result = runner.invoke(cli, ["system", "health"])
     assert result.exit_code == 0
@@ -129,8 +121,6 @@ def test_cli_health_up_exits_zero(mock_service: MagicMock, runner: CliRunner) ->
 @patch("aignostics.system._cli._service")
 def test_cli_health_degraded_exits_zero(mock_service: MagicMock, runner: CliRunner) -> None:
     """Check health command exits with code 0 when status is DEGRADED."""
-    from aignostics.utils import Health
-
     mock_service.health = AsyncMock(return_value=Health(status=Health.Code.DEGRADED, reason="some component degraded"))
     result = runner.invoke(cli, ["system", "health"])
     assert result.exit_code == 0
@@ -140,8 +130,6 @@ def test_cli_health_degraded_exits_zero(mock_service: MagicMock, runner: CliRunn
 @patch("aignostics.system._cli._service")
 def test_cli_health_down_exits_one(mock_service: MagicMock, runner: CliRunner) -> None:
     """Check health command exits with code 1 when status is DOWN."""
-    from aignostics.utils import Health
-
     mock_service.health = AsyncMock(return_value=Health(status=Health.Code.DOWN, reason="service unavailable"))
     result = runner.invoke(cli, ["system", "health"])
     assert result.exit_code == 1