test(platform): activate 2nd leg, i.e. find and validate tests

Author: helmut-hoffer-von-ankershoffen

src/aignostics/utils/_constants.py

@@ -19,7 +19,12 @@
 __is_development_mode__ = "uvx" not in sys.argv[0].lower()
 __is_running_in_container__ = os.getenv(f"{__project_name__.upper()}_RUNNING_IN_CONTAINER")
 
-__is_cli_mode__ = sys.argv[0].endswith(__project_name__) or (len(sys.argv) > 1 and sys.argv[1] == __project_name__)
+__is_cli_mode__ = (
+    sys.argv[0].endswith(__project_name__)
+    or (len(sys.argv) > 1 and sys.argv[1] == __project_name__)
+    or sys.argv[0].endswith("gui_watch.py")
+    or (len(sys.argv) > 1 and sys.argv[1] == "gui_watch.py")
+)
 __is_library_mode__ = not __is_cli_mode__ and not os.getenv(f"PYTEST_RUNNING_{__project_name__.upper()}")
 __is_test_mode__ = "pytest" in sys.modules and os.getenv(f"PYTEST_RUNNING_{__project_name__.upper()}")
 

tests/aignostics/platform/e2e_test.py

@@ -55,8 +55,8 @@
     60 * 60
 )  # 1 hour - timeout should never happen if cancel on deadline exceeded works
 
-TEST_APPLICATION_SUBMIT_AND_FIND_DEADLINE_SECONDS = 60 * 60 * 12  # 24 hours
-TEST_APPLICATION_SUBMIT_AND_FIND_DUE_DATE_SECONDS = 60 * 60 * 12  # 24 hours
+TEST_APPLICATION_SUBMIT_AND_FIND_DEADLINE_SECONDS = 60 * 60 * 1  # 1 hours
+TEST_APPLICATION_SUBMIT_AND_FIND_DUE_DATE_SECONDS = 60 * 60 * 1  # 1 hours
 TEST_APPLICATION_SUBMIT_AND_FIND_SUBMIT_TIMEOUT_SECONDS = 60 * 10  # 10 minutes
 TEST_APPLICATION_SUBMIT_AND_FIND_FIND_AND_VALIDATE_TIMEOUT_SECONDS = 60 * 30  # 30 minutes
 
@@ -66,8 +66,8 @@
     60 * 60 * 5
 )  # 5 hours - timeout should never happen if cancel on deadline exceeded works
 
-HETA_APPLICATION_SUBMIT_AND_FIND_DUE_DATE_SECONDS = 60 * 60 * 12  # 24 hours
-HETA_APPLICATION_SUBMIT_AND_FIND_DEADLINE_SECONDS = 60 * 60 * 12  # 24 hours
+HETA_APPLICATION_SUBMIT_AND_FIND_DUE_DATE_SECONDS = 60 * 60 * 12  # 12 hours
+HETA_APPLICATION_SUBMIT_AND_FIND_DEADLINE_SECONDS = 60 * 60 * 12  # 12 hours
 HETA_APPLICATION_SUBMIT_AND_FIND_SUBMIT_TIMEOUT_SECONDS = 60 * 10  # 10 minutes
 HETA_APPLICATION_SUBMIT_AND_FIND_FIND_AND_VALIDATE_TIMEOUT_SECONDS = 60 * 30  # 30 minutes
 
@@ -278,12 +278,14 @@ def _submit_and_wait(  # noqa: PLR0913, PLR0917
         _validate_output(run, Path(temp_dir), checksum_attribute_key)
 
 
-def _find_and_validate(
+def _find_and_validate(  # noqa: PLR0913, PLR0917
     application_id: str,
     application_version: str,
     payload: list[platform.InputItem],
     due_date_seconds: int,
     deadline_seconds: int,
+    timeout_seconds: int,
+    checksum_attribute_key: str = "checksum_base64_crc32c",
 ) -> Run:
     """Find application run submitted earlier and validate its details.
 
@@ -293,13 +295,35 @@ def _find_and_validate(
         payload (list[platform.InputItem]): The input items for the application run.
         due_date_seconds (int): The due date in seconds from now for the application run.
         deadline_seconds (int): The deadline in seconds from now for the application run.
+        timeout_seconds (int): The timeout in seconds to wait for the application run to complete.
+        checksum_attribute_key (str): The key used to validate the checksum of the output artifacts.
 
     Raises:
         AssertionError: If any of the validation checks fail.
     """
     client = platform.Client()
     assert client is not None, "Failed to create platform client"
-    # TODO(Helmut): Build logic to find the run based on metadata once supported
+    now = datetime.now(tz=UTC)
+    check_this_hour_tag = f"find_and_validate:{now.month}_{now.day}_{now.hour}"
+    runs = client.runs.list(
+        application_id=application_id,
+        application_version=application_version,
+        custom_metadata=f'$.sdk.tags[*] ? (@ == "{check_this_hour_tag}")',
+    )
+    checked_runs = 0
+    for run in runs:
+        checked_runs += 1
+        details = run.details()
+        assert details.application_id == application_id, (
+            f"Listed run `{run.run_id}` has unexpected application id `{details.application_id}`"
+        )
+        assert details.version_number == application_version, (
+            f"Listed run `{run.run_id}` has unexpected application version `{details.version_number}`"
+        )
+        with tempfile.TemporaryDirectory() as temp_dir:
+            run.download_to_folder(temp_dir, checksum_attribute_key, timeout_seconds=timeout_seconds)
+            _validate_output(run, Path(temp_dir), checksum_attribute_key)
+    assert checked_runs > 0, "Expected to find at least one run to validate, but found none."
 
 
 @pytest.mark.e2e
@@ -360,7 +384,7 @@ def test_platform_heta_app_submit_and_wait(record_property) -> None:
     )
 
 
-@pytest.mark.skip(reason="Trialing post having moved HETA to submit and find approach")
+@pytest.mark.skip(reason="Using submit and wait approach")
 @pytest.mark.e2e
 @pytest.mark.long_running
 @pytest.mark.timeout(timeout=TEST_APPLICATION_SUBMIT_AND_FIND_SUBMIT_TIMEOUT_SECONDS)
@@ -384,11 +408,10 @@ def test_platform_test_app_submit() -> None:
     )
 
 
-@pytest.mark.skip(reason="To be implemented by Helmut EOD")
 @pytest.mark.e2e
 @pytest.mark.very_long_running
 @pytest.mark.scheduled_only
-@pytest.mark.timeout(timeout=TEST_APPLICATION_SUBMIT_AND_FIND_FIND_AND_VALIDATE_TIMEOUT_SECONDS)
+@pytest.mark.timeout(timeout=TEST_APPLICATION_SUBMIT_AND_FIND_FIND_AND_VALIDATE_TIMEOUT_SECONDS + 60 * 5)
 def test_platform_test_app_find_and_validate() -> None:
     """Test application runs with the test application.
 
@@ -406,6 +429,7 @@ def test_platform_test_app_find_and_validate() -> None:
         ),
         deadline_seconds=TEST_APPLICATION_SUBMIT_AND_FIND_DEADLINE_SECONDS,
         due_date_seconds=TEST_APPLICATION_SUBMIT_AND_FIND_DUE_DATE_SECONDS,
+        timeout_seconds=TEST_APPLICATION_SUBMIT_AND_FIND_FIND_AND_VALIDATE_TIMEOUT_SECONDS,
     )
 
 
@@ -433,11 +457,10 @@ def test_platform_heta_app_submit() -> None:
     )
 
 
-@pytest.mark.skip(reason="To be implemented by Helmut EOD")
 @pytest.mark.e2e
 @pytest.mark.very_long_running
 @pytest.mark.scheduled_only
-@pytest.mark.timeout(timeout=HETA_APPLICATION_SUBMIT_AND_FIND_FIND_AND_VALIDATE_TIMEOUT_SECONDS)
+@pytest.mark.timeout(timeout=HETA_APPLICATION_SUBMIT_AND_FIND_FIND_AND_VALIDATE_TIMEOUT_SECONDS + 60 * 5)
 def test_platform_heta_app_find_and_validate() -> None:
     """Test application runs with the HETA application.
 
@@ -455,6 +478,7 @@ def test_platform_heta_app_find_and_validate() -> None:
         ),
         deadline_seconds=HETA_APPLICATION_SUBMIT_AND_FIND_DEADLINE_SECONDS,
         due_date_seconds=HETA_APPLICATION_SUBMIT_AND_FIND_DUE_DATE_SECONDS,
+        timeout_seconds=TEST_APPLICATION_SUBMIT_AND_FIND_FIND_AND_VALIDATE_TIMEOUT_SECONDS,
     )
 
 
@@ -473,7 +497,7 @@ def _validate_output(
         checksum_attribute_key (str): The key used to validate the checksum of the output artifacts.
     """
     # validate run state
-    run_details = application_run.details()
+    run_details = application_run.details(nocache=True)
     assert run_details.state == RunState.TERMINATED, (
         f"Run `{application_run.run_id}`: "
         f"Did not finish in state `TERMINATED`, but `{run_details.state}`.\n"