The lemmyv1 adapter currently normalizes JSON null to undefined in a few places because the Lemmy 1.0 beta wire format returns null for absent optional fields rather than omitting them.
nullToUndef helper used on notification.{comment_id,modlog_id,post_id,private_message_id} (src/providers/lemmyv1/compat.ts:196-199)
== null (instead of === undefined) checks against PostActions.{vote_is_upvote,read_comments_at} (src/providers/lemmyv1/compat.ts:270,289)
These workarounds papered over schemas that expect undefined. Once Lemmy stabilizes 1.0, recheck whether the server actually emits null for these fields and either:
- Update our schemas to accept
null explicitly (z.nullish) and drop the helpers, or
- Confirm the server omits the fields and remove the normalization.
The lemmyv1 adapter currently normalizes JSON
nulltoundefinedin a few places because the Lemmy 1.0 beta wire format returnsnullfor absent optional fields rather than omitting them.nullToUndefhelper used onnotification.{comment_id,modlog_id,post_id,private_message_id}(src/providers/lemmyv1/compat.ts:196-199)== null(instead of=== undefined) checks againstPostActions.{vote_is_upvote,read_comments_at}(src/providers/lemmyv1/compat.ts:270,289)These workarounds papered over schemas that expect
undefined. Once Lemmy stabilizes 1.0, recheck whether the server actually emitsnullfor these fields and either:nullexplicitly (z.nullish) and drop the helpers, or