Tracking payments by others, debts, budgeting

[Sha-yol]

The main selling point of Firefly (hence FF) for me was the budgeting (besides self hosting).
Budgeting doesn't work with Splitwise (hence SW) - if I pay 10 for groceries, but split it with my roommate, only my share - 5 - should come out of my groceries budget. However, if I want FF to actually match money moving out of my account, and match transactions to my bank statement - well, there will be a transaction of 10 to the grocery store, so FF should have a txn for 10.
Complication 1: I payed 10, but my actual assets should have decreased only by 5 - since my roommate now owes me 5 for the groceries.
Complication 2: my roommate is the one who bought groceries. Currently, if my roommate hasn't added the special comment, nothing will happen on my FF, and indeed no money moved out of my account. However, I have used up some of my groceries budget, and my total assets should have decreased by the same amount, since I owe my roommate my share.

I suggest resolving all of those in one fell swoop:

1. Create another asset account to hold SW balance.
2. If I payed 10 and my share is 5:
   1. create a split txn on FF: one part titled with the original SW description, the other part titled "splitwise loan" or something like that. Then, I can manually (or using FF rules) take my share from the relevant budget.
   2. create a deposit to SW balance account, either from my roommate's account or from generic "Splitwise" account
3. If I payed 0 and my share is 5:
   1. Do not create a transaction from my real accounts, since no money moved.
   2. Create a withdrawal from the "SW balance" account. Can manually subtract it from relevant budget.
4. Combo: I payed less than my share. Roommate was short on cash, they payed 7, I payed 3, my share was 5.
   1. Create withdrawal from account for 3.
   2. Create withdrawal from SW balance account for 2.

This would require a major overhaul of the transaction creation, and updating would require tracking several transactions on FF.
Thoughts on this proposed solution?

[adyanth]

Thanks for creating the issue, this is something I experience as well. For the problem 2, I just add a comment when I get a notification that someone split an expense with me.

1 is complicated as you note, causing multiple transactions to be handled, and also requiring to check settle up information to remove those (which might also vary since one friend might send it to a bank account vs another who might send it to a mobile wallet for example).

I like the idea of a splitwise balance (asset? loan?) account (this would need to be behind a feature switch, I would not assume others following that workflow) and what you propose.

PS: Also remember that you can add budget along with category if you so need from the text (without falling back to FF rules), it would be a simple code change to do that.

[Sha-yol]

Alright, so I'll leave complication 2 as it is, and I'll solve it by adding a comment myself.

Re settle up information: I don't think settle up should complicate things - not sure how it's represented on SW, but a settlement is simply a transaction, no?

• If we settle by me paying my friend: add a transfer txn from my account to the splitwise balance account on FF. Actual money has left my account, but my total assets haven't decreased, since I was paying off a debt.
• The reverse happens if we settle by my friend paying me: a transfer from the splitwise balance account to my asset account. Actual money entered my account, but my total assets haven't changed.

Re adding budget with comment: does the current comment parsing support that? Or would that require a change to the parsing?

[adyanth]

What you describe is right, but which asset account would you select to move money to/from the SW balance account?

For budget, I meant mapping categories to budgets in the sync using a lookup config, since an expense category is unlikely to change budgets.

[Sha-yol]

• re settlements: As of current implementation, the syncer skips payments and settlments. We can:
  1. Leave it as it is for the first iteration, and have users add those manually - they will be simpler to add, just a single FF transaction.
  2. Parse comments on those "expenses" using a simpler format, Firefly/account/category, where "account" is the partner of the SW balance account in the transfer.
  3. Use the default account defined in the .env file. Can be combined with option 2.
• re budget: I actually have diffrent categories and budgets 😅 not sure if its a great idea, but since FF allows it, I wouldn't want to assume that no one else does that.

[adyanth]

I am good with leaving it as is and iterating on it.

Could you give an example of how a single category belongs in different budgets? FF allows it, but if it is not a major use case, it might be good for keeping the syncer simple, but if it is a good use case, then I agree, falling back to FF automation is not a bad idea.

[Sha-yol]

A recent usage of mine - I was travelling abroad, and I ate at a restaurant. Normally it would come out of my "eating out" budget, but this time it came out of my "vacations" budget. Still, it is categorized under the "eating out" *category*. Another example could be having a dedicated budget for activities with a partner, but categorizing each expense as movies, restaurants, bars, etc. I think of the difference as - "category" is what kind of thing I bought with the money, which is divorced from what is the reason for spending that money, which has to do with what budget it came from. I'm still learning FF, to be honest, so I might collapse budgets and categories further down the line. I'm willing to have that as a default, but I'd prefer having the default not file the txn under a budget at all.

…

On Tue, 8 Oct 2024 at 02:47, Adyanth Hosavalike ***@***.***> wrote: I am good with leaving it as is and iterating on it. Could you give an example of how a single category belongs in different budgets? FF allows it, but if it is not a major use case, it might be good for keeping the syncer simple, but if it is a good use case, then I agree, falling back to FF automation is not a bad idea. — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHU22STWFFZ63RPQNBJINQLZ2MMP5AVCNFSM6AAAAABOHFBVMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJYGE4TAMZUGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[adyanth]

I think that is accurate for using categories and budgets!

[Sha-yol]

So I'll continue without filing the transaction under a budget matching the category. We can think later about adding a budget option to the Splitwise comment string.

…

On Wed, Oct 9, 2024, 03:27 Adyanth Hosavalike ***@***.***> wrote: I think that is accurate for using categories and budgets! — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHU22STEFOUYPNW6T4PO4JDZ2RZ5ZAVCNFSM6AAAAABOHFBVMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGAZTQOJXGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[Sha-yol]

Which is better for implementing the feature switch:
Dependency injection of the switch into processExpense
Or creating an abstract TransactionStrategy class and implementing two classes, one for each behavior? Could be an overkill, but is cleaner and would leave room for other strategies down the line.

[adyanth]

An abc (or a protocol) would be a good way to implement it as you suggest. Although I wouldn't not accept a PR with a boolean switch.

[Sha-yol]

Ok. Now that the debt tracker is done, another question: I want to write the split-transaction feature, that splits getPaidShare into a split FF journal, with one txn of amount getOwedShare with the original description and another with of amount getNetBalance with a description like "Splitwise cover" or something. This will allow filing the getOwedShare txn under the appropriate budget.
Here's the question: should it be behind an independent feature switch? Does it make sense to want the split txn feature but not the debt tracker feature? I think it does, but raises the question of how to extend the strategy patten to take that into account. A SWBalanceAndSplitTransactionStrategy, calling the individual strategies? Could work for now since we have only 1 combination of two features, but not sustainable for future optional features.
What do you think?

[adyanth]

The split transaction feature would only work to split the single SW transaction into an owed and paid transaction right? In which case, I do not see what you could do with those transactions without debt tracking. Or maybe I'm mistaken?